Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jennifer,
Nice work on getting threaded replies working in bbPress!
While working on a plugin for BuddyPress, I wanted to reference your plugin to give users the option to either view discussion threads as linear or threaded.
However, when it came time to hook into your plugin for the threaded option, I couldn't hook into your class methods because of the dual usage of static vs. non-static class properties.
Commit 7dde17b changes the properties in the
UCC_bbPress_Threaded_Replies_Loader
class to static as originally referenced before the class constructor.This allows me to access your awesome class methods when needed.
As for the other commits:
Let me know what you think when you have a moment!