Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook for fitting of stretched exponential #50

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jmborr
Copy link
Owner

@jmborr jmborr commented Apr 16, 2018

Description of work.

To test:

Fixes #49

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the [coding standards]?
  • Are the unit tests small and test the class in isolation?
  • If there are changes in HISTORY.rst then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @qef/gatekeepers will take care of it.

@jmborr jmborr added this to the v0.3.0 milestone Apr 16, 2018
@jmborr jmborr self-assigned this Apr 16, 2018
@jmborr jmborr force-pushed the 49_notebook_strexp branch from 5c843f1 to 49620ae Compare April 18, 2018 23:53
Repository owner deleted a comment from codecov-io Apr 19, 2018
@jmborr jmborr force-pushed the 49_notebook_strexp branch from 49620ae to 6843c49 Compare April 19, 2018 19:52
Repository owner deleted a comment from codecov-io Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant