Skip to content

Commit

Permalink
Comment changes to AppCeyor config
Browse files Browse the repository at this point in the history
  • Loading branch information
pont-us committed Nov 27, 2020
1 parent 208c1b3 commit 90f7297
Showing 1 changed file with 16 additions and 8 deletions.
24 changes: 16 additions & 8 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ environment:
JPY_PYTHON_HOME_UBUNTU: /home/appveyor/venv3.4
JPY_MAC_PYTHON_VERSION: 3.4.10
# Python 3.4 is incompatible with OpenSSL 1.1, so we have to force the
# installation of OpenSSL 1.0 (see https://bugs.python.org/issue31838
# and https://gist.github.com/souzagab/0ae60e61939d51385de87904b65b2da2 ).
# installation of OpenSSL 1.0 (see https://bugs.python.org/issue31838 ,
# https://gist.github.com/souzagab/0ae60e61939d51385de87904b65b2da2 ,
# and more detailed comments below).
JPY_MAC_OPENSSL_PACKAGE: openssl.rb
- JPY_PYTHON_HOME_WINDOWS: C:\Python35-x64
JPY_PYTHON_HOME_UBUNTU: /home/appveyor/venv3.5
Expand Down Expand Up @@ -112,15 +113,22 @@ for:
# use brew to install pyenv and pyenv to install a 10.9-targeted Python
# environment.
#
- brew update
# The Python 3.4 Mac build is particularly challenging, because Python 3.4
# is incompatible with OpenSSL 1.1, and OpenSSL 1.0 is no longer supported
# by homebrew. We install OpenSSL 1.0 by directly specifying the URL of
# the appropriate homebrew formula, set a lot of environment variables to
# make sure that pyenv can find it, then uninstall version 1.1. (For the
# Python 3.8 build, OpenSSL 1.1 is then automatically reinstalled by pyenv.)
# Most of this configuration can be removed once we drop Python 3.4 support.
- brew update
# by homebrew. We install OpenSSL 1.0 by explicitly fetching the 1.0
# formula from an old revision in the homebrew repository and installing
# from the downloaded file. Then we set a lot of environment variables to
# make sure that pyenv can find the newly installed openssl and uninstall
# version 1.1. (For the Python >3.4 builds, OpenSSL 1.1 is then
# automatically reinstalled by pyenv.) Most of this configuration can be
# removed once we drop Python 3.4 support.
#
# As of October 2020, "brew install" forbids installation of openssl from
# a GitHub commit URL, so we fetch it with curl and install from the file.
- curl https://raw.githubusercontent.com/Homebrew/homebrew-core/64555220bfbf4a25598523c2e4d3a232560eaad7/Formula/openssl.rb > openssl.rb
# For Python 3.4, $JPY_MAC_OPENSSL_PACKAGE should contain the name of the
# downloaded file; for newer Pythons, "[email protected]".
- brew install -f $JPY_MAC_OPENSSL_PACKAGE
- brew install pyenv
- export ssldir=/usr/local/opt/openssl
Expand Down

0 comments on commit 90f7297

Please sign in to comment.