Skip to content

Commit

Permalink
removed bug where attributes with value None are converted to string …
Browse files Browse the repository at this point in the history
…'None'
  • Loading branch information
jkminder committed Mar 7, 2022
1 parent 050a4df commit e701f15
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ The library is built specifically for converting data into a [neo4j](https://neo

Note: The [py2neo](https://py2neo.org/2021.1/index.html) library does not support parallel relations of the same type (same source, same target and same type). If your graph requires such parallel relations please checkout the provided [py2neo extensions](/docs/documentation.md#py2neo-extensions).
## Installation
If you have setup a private ssh key for your github, copy-paste the command below to install the latest version ([v0.4.4][latest_tag]):
If you have setup a private ssh key for your github, copy-paste the command below to install the latest version ([v0.4.5][latest_tag]):
```
$ pip install git+ssh://[email protected]/sg-dev/[email protected].4
$ pip install git+ssh://[email protected]/sg-dev/[email protected].5
```

If you don't have ssh set up, download the latest wheel [here][latest_wheel] and install the wheel with:
Expand Down Expand Up @@ -85,7 +85,7 @@ converter()
# Known issues
If you encounter a bug or an unexplainable behavior, please check the [known issues](https://github.com/sg-dev/rel2graph/labels/bug) list. If your issue is not found, submit a new one.

[latest_version]: v0.4.4
[latest_tag]: https://github.com/sg-dev/rel2graph/releases/tag/v0.4.4
[latest_wheel]: https://github.com/sg-dev/rel2graph/releases/download/v0.4.4/rel2graph-0.4.4-py3-none-any.whl
[latest_version]: v0.4.5
[latest_tag]: https://github.com/sg-dev/rel2graph/releases/tag/v0.4.5
[latest_wheel]: https://github.com/sg-dev/rel2graph/releases/download/v0.4.5/rel2graph-0.4.5-py3-none-any.whl
[wiki]: docs/documentation.md
2 changes: 1 addition & 1 deletion rel2graph/core/graph_elements.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def key(self):
def value(self):
"""Any value that is allowed in the graph (String, Int, Float, Bool)"""
# If the value is not allowed in neo4j it is converted to strings
if not isinstance(self._value, (numbers.Number, str, bool, date, datetime)):
if not self._value is None and not isinstance(self._value, (numbers.Number, str, bool, date, datetime)):
return str(self._value)
return self._value

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
setup(
name = "rel2graph",
packages = find_packages(),
version = "0.4.4",
version = "0.4.5",
description = "Library for converting relational data into graph data (neo4j)",
author = "Julian Minder",
author_email = "[email protected]",
Expand Down

0 comments on commit e701f15

Please sign in to comment.