code optimised

jinnthehuman · Aug 12, 2024 · 0730417 · 0730417
1 parent a2feabb
commit 0730417
Showing 1 changed file with 21 additions and 44 deletions.
diff --git a/src/jobs/submitJob.tsx b/src/jobs/submitJob.tsx
@@ -495,50 +495,27 @@ function SubmitJob({
     jarFileSelected: string[] | string,
     argumentSelected: string[] | string
   ) => {
-    if(mainClassSelected.includes('.jar')){
-      return {
-        sparkJob: {
-          mainJarFileUri: mainClassSelected,
-          ...(propertyObject && {
-            properties: propertyObject
-          }),
-          ...(archieveFileSelected !== '' && {
-            archiveUris: archieveFileSelected
-          }),
-          ...(fileSelected !== '' && {
-            fileUris: [fileSelected]
-          }),
-          ...(jarFileSelected !== '' && {
-            jarFileUris: jarFileSelected
-          }),
-          ...(argumentSelected !== '' && {
-            args: argumentSelected
-          })
-        }
-      };
-    }
-    else{
-      return {
-        sparkJob: {
-          mainClass: mainClassSelected,
-          ...(propertyObject && {
-            properties: propertyObject
-          }),
-          ...(archieveFileSelected !== '' && {
-            archiveUris: archieveFileSelected
-          }),
-          ...(fileSelected !== '' && {
-            fileUris: [fileSelected]
-          }),
-          ...(jarFileSelected !== '' && {
-            jarFileUris: jarFileSelected
-          }),
-          ...(argumentSelected !== '' && {
-            args: argumentSelected
-          })
-        }
-      };
-    }
+    const isJar = mainClassSelected.includes('.jar');
+    return {
+      sparkJob: {
+        ...(isJar ? { mainJarFileUri: mainClassSelected } : { mainClass: mainClassSelected }),
+        ...(propertyObject && {
+          properties: propertyObject
+        }),
+        ...(archieveFileSelected !== '' && {
+          archiveUris: archieveFileSelected
+        }),
+        ...(fileSelected !== '' && {
+          fileUris: [fileSelected]
+        }),
+        ...(jarFileSelected !== '' && {
+          jarFileUris: jarFileSelected
+        }),
+        ...(argumentSelected !== '' && {
+          args: argumentSelected
+        })
+      }
+    };
   };
 
   const createSparkRPayload = (