-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement base type-level interpreter and subtyping #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CohenArthur
commented
Dec 17, 2023
- [wip]: Start working on type var interpreter. Bring over UnionType from FIR
- [wip]: Go further with the typelevel interpreter
- [wip] it compiles
- [wip]: Improve errors and API
- wip: Add proper handling of Kind::UnionType
- [wip] almost there
- [wip] it fucken works ~ ! ! ~
- typecheck: Start adding TypeMap data structure
- typecheck: Start making TypeCtx generic
Once this is done we can probably merge this
|
4dd3690
to
b2005dd
Compare
So what we actually want is to have something like the following API: fn insert_type(key: OriginIdx, ty: Type) -> TypeReference {}
fn insert(key: OriginIdx, tyref: TypeReference) {} |
|
This is useful as type aliases are flattened to TypeReferences that are already resolved
9f9961f
to
8e12321
Compare
00f48dd
to
0256bb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.