Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix job using cargo clippy instead of cargo check #584

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

ci: fix job using cargo clippy instead of cargo check #584

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fff1b91
ci: fix job using cargo clippy instead of cargo check
tanguysegarra Sep 2, 2022
0b5c133
break clippy
tanguysegarra Sep 13, 2022
444ee4d
ci: remove double clippy usage
tanguysegarra Sep 14, 2022
6d1103c
Revert "break clippy"
tanguysegarra Sep 18, 2022
dc7dc93
remove build from bors
tanguysegarra Sep 18, 2022
29d3e38
fix bors?
tanguysegarra Sep 18, 2022
3de76e9
remove build from bors
tanguysegarra Sep 18, 2022
76743d6
no bors + build step:
tanguysegarra Sep 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions .github/workflows/build_test_fmt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,16 @@ jobs:
run: |
cargo fmt -- --check

build:
runs-on: ubuntu-latest
needs: coding-style

steps:
- uses: actions/checkout@v2
- name: Build jinko
run: |
cargo clippy

build-without-warnings:
runs-on: ubuntu-latest
needs: build

steps:
- uses: actions/checkout@v2
- name: Make sure that the build completes without any warnings
env:
RUSTFLAGS: "-D warnings" # Trigger an error on warnings
run: |
cargo clippy
cargo check

tests-check:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion src/typechecker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use std::{
/// The [`CheckedType`] enum contains three possible states about the type. Either the
/// type has been properly resolved to something, or it corresponds to a Void type. If the
/// type has not been resolved yet, it can be unknown.
#[derive(Clone, PartialEq, Eq, Debug)]
#[derive(Clone, PartialEq, Debug)]
pub enum CheckedType {
Resolved(TypeId),
// Should we remove this for Resolved(TypeId::void())?
Expand Down