Add qodana CI checks (do not merge, PR for research) #1
1057 new problems found by Qodana for .NET
Qodana for .NET
1057 new problems were found
Inspection name | Severity | Problems |
---|---|---|
Redundant cast |
🔶 Warning | 175 |
Redundant arithmetic overflow checking context |
🔶 Warning | 139 |
Unused parameter (private accessibility) |
🔶 Warning | 16 |
Possible 'System.NullReferenceException' |
🔶 Warning | 14 |
Redundant using directive |
🔶 Warning | 11 |
Redundant namespace alias |
🔶 Warning | 11 |
Namespace does not correspond to file location |
🔶 Warning | 9 |
Type member is never used (private accessibility) |
🔶 Warning | 7 |
Parameter hides member |
🔶 Warning | 5 |
Unresolved binding path when DataContext is known |
🔶 Warning | 5 |
Overridden property |
🔶 Warning | 4 |
Member hides static member from outer class |
🔶 Warning | 4 |
The pattern is redundant, it does not produce any runtime checks |
🔶 Warning | 4 |
Unknown property |
🔶 Warning | 2 |
Overriding property |
🔶 Warning | 2 |
Redundant explicit type in array creation |
🔶 Warning | 2 |
Unassigned readonly field |
🔶 Warning | 2 |
Missing grid column/row setter for non-first child |
🔶 Warning | 2 |
Possible 'null' assignment to non-nullable entity |
🔶 Warning | 1 |
Deprecated property |
🔶 Warning | 1 |
Redundant property |
🔶 Warning | 1 |
Empty constructor |
🔶 Warning | 1 |
Invalid XML documentation comment |
🔶 Warning | 1 |
Non-accessed field (private accessibility) |
🔶 Warning | 1 |
Private field can be converted into local variable |
🔶 Warning | 1 |
Redundant lambda expression parameter type specification |
🔶 Warning | 1 |
Type member is never used (non-private accessibility) |
◽️ Notice | 245 |
Adjust modifiers declaration order |
◽️ Notice | 72 |
Unresolved binding path when DataContext is unknown |
◽️ Notice | 48 |
Member can be made private (non-private accessibility) |
◽️ Notice | 38 |
Use explicit or implicit modifier definition for type members |
◽️ Notice | 27 |
Type is never used (non-private accessibility) |
◽️ Notice | 26 |
Remove redundant parentheses |
◽️ Notice | 24 |
Add/remove 'this.' qualifier |
◽️ Notice | 24 |
Method return value is never used (non-private accessibility) |
◽️ Notice | 12 |
Use preferred style of 'new' expression when created type is evident |
◽️ Notice | 10 |
Use preferred body style (convert into property, indexer, or event with preferred body style) |
◽️ Notice | 9 |
Field can be made readonly (private accessibility) |
◽️ Notice | 8 |
Add/remove qualifier for static members |
◽️ Notice | 6 |
Use preferred 'var' style (when type is simple) |
◽️ Notice | 6 |
Unassigned field (non-private accessibility) |
◽️ Notice | 6 |
Class is never instantiated (non-private accessibility) |
◽️ Notice | 5 |
'if-return' statement can be rewritten as 'return' statement |
◽️ Notice | 5 |
Use string interpolation expression |
◽️ Notice | 5 |
Use preferred style for trailing comma before new line in multiline lists |
◽️ Notice | 4 |
Merge null/pattern/value checks into 'or'/'and' patterns |
◽️ Notice | 4 |
Use preferred 'var' style (for built-in types) |
◽️ Notice | 4 |
RoslynAnalyzers Mark members as static |
◽️ Notice | 3 |
Convert 'if' statement into 'switch' |
◽️ Notice | 3 |
Overlapping sections |
◽️ Notice | 3 |
Inline 'out' variable declaration |
◽️ Notice | 3 |
Invert 'if' statement to reduce nesting |
◽️ Notice | 3 |
Member can be made static (shared) (non-private accessibility) |
◽️ Notice | 3 |
Property can be made init-only (non-private accessibility) |
◽️ Notice | 3 |
Redundant verbatim string prefix |
◽️ Notice | 3 |
Convert property into auto-property |
◽️ Notice | 2 |
Convert property into auto-property (when possible) |
◽️ Notice | 2 |
Field can be made readonly (non-private accessibility) |
◽️ Notice | 2 |
Type check and casts can be merged |
◽️ Notice | 2 |
Redundant semicolon after type or namespace declaration |
◽️ Notice | 2 |
Auto-property can be made get-only (private accessibility) |
◽️ Notice | 1 |
Replace built-in type reference with a CLR type name or a keyword |
◽️ Notice | 1 |
Dictionary lookup can be simplified with 'GetValueOrDefault' |
◽️ Notice | 1 |
Replace 'switch' statement with 'switch' expression |
◽️ Notice | 1 |
Convert into lambda expression |
◽️ Notice | 1 |
Merge nested property patterns |
◽️ Notice | 1 |
Non-accessed field (non-private accessibility) |
◽️ Notice | 1 |
Parameter output value is always discarded (non-private accessibility) |
◽️ Notice | 1 |
Redundant empty argument list on object creation expression |
◽️ Notice | 1 |
Redundant 'else' keyword |
◽️ Notice | 1 |
Return type can be IEnumerable<T> (non-private accessibility) |
◽️ Notice | 1 |
Replace if statement with null-propagating code |
◽️ Notice | 1 |
Grid columns/rows definitions can be converted to attribute |
◽️ Notice | 1 |
☁️ View the detailed Qodana report
Detected 71 dependencies
Third-party software list
This page lists the third-party software dependencies used in Consolonia
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check notice on line 58 in Consolonia.GuiCS/handles.cs
github-actions / Qodana for .NET
Use preferred body style (convert into property, indexer, or event with preferred body style)
Code body does not conform to code style settings: use expression-bodied property
Check notice on line 174 in Consolonia.GuiCS/Size.cs
github-actions / Qodana for .NET
Use preferred body style (convert into property, indexer, or event with preferred body style)
Code body does not conform to code style settings: use expression body
Check notice on line 131 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Use preferred body style (convert into property, indexer, or event with preferred body style)
Code body does not conform to code style settings: use expression-bodied property
Check notice on line 141 in Consolonia.GuiCS/Size.cs
github-actions / Qodana for .NET
Use preferred body style (convert into property, indexer, or event with preferred body style)
Code body does not conform to code style settings: use expression-bodied property
Check notice on line 52 in Consolonia.GuiCS/handles.cs
github-actions / Qodana for .NET
Use preferred body style (convert into property, indexer, or event with preferred body style)
Code body does not conform to code style settings: use expression-bodied property
Check notice on line 31 in Consolonia.GuiCS/WindowsDriver.cs
github-actions / Qodana for .NET
Use preferred body style (convert into property, indexer, or event with preferred body style)
Code body does not conform to code style settings: use expression body
Check notice on line 155 in Consolonia.GuiCS/Size.cs
github-actions / Qodana for .NET
Use preferred body style (convert into property, indexer, or event with preferred body style)
Code body does not conform to code style settings: use expression body
Check notice on line 125 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Use preferred body style (convert into property, indexer, or event with preferred body style)
Code body does not conform to code style settings: use expression-bodied property
Check notice on line 164 in Consolonia.GuiCS/Point.cs
github-actions / Qodana for .NET
Use preferred body style (convert into property, indexer, or event with preferred body style)
Code body does not conform to code style settings: use expression-bodied property
Check notice on line 312 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 276 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 304 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 297 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 78 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 282 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 242 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 264 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 292 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 258 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 301 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 318 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 314 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 285 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 260 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order
Check notice on line 280 in Consolonia.GuiCS/binding.cs
github-actions / Qodana for .NET
Adjust modifiers declaration order
Inconsistent modifiers declaration order