Upgrade Avalonia to 11.2.1 #152

tomlm · 2024-11-20T05:30:57Z

I bumped version to 11.2.1
I updated signature for changed methods
implemented stubs for called methods which seem ok to ignore
have not ImplementedException stubs for things I don't know if we need or not.
Fixed some things that are obselete (RadiusX and RadiusY instead of Radius for example)

Everything seems to work except

Menu
ComboBox
Dialog

They are blowing up inside KeyboardNavigationHandler, I don't know what those are/do, so I am pushing this branch up there. Maybe the solution is obvious to you?

They alll throw an exception having to do with layering? Given there are new layering APIs added, it seems related.

coderabbitai · 2024-11-20T05:31:04Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Co-authored-by: <[email protected]>

src/Consolonia.Core/Drawing/ConsoloniaPlatformRenderInterfaceContext.cs

src/Consolonia.Core/Drawing/RenderTarget.cs

src/Consolonia.Core/Infrastructure/ConsoleWindow.cs

jinek · 2024-11-28T19:14:30Z

src/Consolonia.Themes.TurboVision/Templates/Controls/Helpers/ConsoloniaTextPresenter.cs

-                TimeSpan.FromMilliseconds(int
-                    .MaxValue); //see DispatcherTimer.Interval, since we can not disable it, setting it to the longest interval possible
-            caretTickTimer!.Tick += (_, _) => throw new NotImplementedException("How to disable timer completely?");
+            // TODO: consider that with avalonia 11.1.5 this is null;


Probably we should investigate how to disable blinking in Avalonia 11.1.5 ?

…ng invoked

jinek · 2024-11-30T18:47:55Z

@tomlm Why did you decide to close this one?

tomlm · 2024-11-30T20:57:43Z

I had a typo in the branch name and renaming the branch closed the PR!

tomlm added 2 commits November 19, 2024 23:13

11.1 seems to work wwith stubbed out interfaces definitions

baf62c1

11.2.1, everything works except for Menu/Dialogs/ComboBox

bce6309

They alll throw an exception having to do with layering? Given there are new layering APIs added, it seems related.

tomlm requested a review from jinek November 20, 2024 05:31

Automated JetBrains cleanup

67e26ed

Co-authored-by: <[email protected]>