Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitmap support #127
Bitmap support #127
Changes from 111 commits
17d9623
bd8e2e3
395c6e2
4dd755d
85d5eac
6e8aa2b
6efaf75
b0cf503
bb117b0
acfc4fd
ed52281
259893e
dc51e56
773b1e6
2eff951
d69b033
575f539
7edf517
40e45ec
2a609ce
52bf2fb
9204d7f
3a2579d
2b66acf
d372108
d0d399f
48d031f
f15265e
874b29d
478fd6a
0e8f835
1ffe787
afb4833
d8e7eef
82b946f
bd34f74
7871b19
a807e3e
4527aec
6cbff99
5944506
eaefba3
112f9ad
456630a
77af91f
e845e75
8efff9e
121221a
8962d2c
d1cbe6b
5f0bd23
36cfbcc
c1de176
1b0ab64
5a84e0f
e9c3497
2dcb1c8
34c9336
fc81b86
0d834d6
8a79a69
8da4f66
ff2767f
98f6ae6
242628b
47de318
32f020e
b38f9cd
784fa2b
0273b81
4cc39fe
ab1617e
2f5df27
b355163
ebf1499
21ab9bf
ac51348
be95d7b
e41651d
7090b8f
f08287d
7c22861
9245be5
1b518d6
b6858fa
c6b906c
5f1bd74
37501e3
cec48c2
8ef8a47
eea9ba7
3b45704
2c28b9e
56daa77
894317d
c1564ff
c5d315c
d2580a4
baca3bb
d5dbd0b
274835d
8befa4b
3307798
8c326f3
eac7395
363ac96
8fa9eb0
8269be1
cdf9689
5c61422
6f3a4c7
e05d357
9217453
3dcecd3
45f5f6d
06383e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice on line 37 in src/Consolonia.Core/Drawing/BitmapImpl.cs
GitHub Actions / build
Check notice on line 73 in src/Consolonia.Core/Drawing/BitmapImpl.cs
GitHub Actions / build
Check notice on line 86 in src/Consolonia.Core/Drawing/BitmapImpl.cs
GitHub Actions / build
Check notice on line 86 in src/Consolonia.Core/Drawing/BitmapImpl.cs
GitHub Actions / build
Check notice on line 186 in src/Consolonia.Core/Drawing/ConsoleBrush.cs
GitHub Actions / build
Check notice on line 65 in src/Consolonia.Core/Drawing/ConsoloniaRenderInterface.cs
GitHub Actions / build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Simplify 'using' Statement with 'using' Declaration
You can simplify the
using
statement by converting it to ausing
declaration, reducing nesting and improving readability.Apply this diff to update the code:
📝 Committable suggestion
🧰 Tools
🪛 GitHub Check: build
[notice] 65-65:
"[ConvertToUsingDeclaration] Convert into 'using' declaration" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/ConsoloniaRenderInterface.cs(65,13)
Check notice on line 79 in src/Consolonia.Core/Drawing/ConsoloniaRenderInterface.cs
GitHub Actions / build
Check notice on line 92 in src/Consolonia.Core/Drawing/ConsoloniaRenderInterface.cs
GitHub Actions / build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Simplify 'using' Statement with 'using' Declaration
Streamline the
using
statement by converting it to ausing
declaration.Apply this diff to update the code:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Simplify 'using' Statement with 'using' Declaration
Convert the
using
statement to ausing
declaration to enhance readability.Apply this diff to update the code:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure safe casting of
bitmapImpl
toBitmapImpl
.Directly casting
bitmapImpl
toBitmapImpl
may cause anInvalidCastException
if the providedIBitmapImpl
is not of typeBitmapImpl
. Consider using theas
operator and checking fornull
, or validate the type before casting.Modify the code to safely handle casting:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle potential errors when installing pixels into
SKBitmap
.The
InstallPixels
method might fail or result in an invalidSKBitmap
. It's important to check the return value and handle any errors.Include error handling after installing pixels:
Check notice on line 148 in src/Consolonia.Core/Drawing/DrawingContextImpl.cs
GitHub Actions / build