fix paste performance issue on windows and linux #632
Annotations
1 error, 11 warnings, and 10 notices
|
Inspect code
Issues found.
|
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Inspect code:
src/Consolonia.PlatformSupport/Clipboard/X11Clipboard.cs#L44
"[AssignNullToNotNullAttribute] Possible 'null' assignment to non-nullable entity" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.PlatformSupport/Clipboard/X11Clipboard.cs(44,53)
|
|
Inspect code:
src/Consolonia.PlatformSupport/Clipboard/ClipboardProcessRunner.cs#L51
"[CA1307] 'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Consolonia.PlatformSupport.Clipboard.ClipboardProcessRunner.FileExists(string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent." on /home/runner/work/Consolonia/Consolonia/src/Consolonia.PlatformSupport/Clipboard/ClipboardProcessRunner.cs(51,53)
|
|
Inspect code:
src/Consolonia.PlatformSupport/PlatformSupportExtensions.cs#L75
"[CA1307] 'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Consolonia.PlatformSupportExtensions.IsWSLPlatform()' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent." on /home/runner/work/Consolonia/Consolonia/src/Consolonia.PlatformSupport/PlatformSupportExtensions.cs(75,34)
|
|
Inspect code:
src/Consolonia.PlatformSupport/PlatformSupportExtensions.cs#L75
"[CA1307] 'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Consolonia.PlatformSupportExtensions.IsWSLPlatform()' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent." on /home/runner/work/Consolonia/Consolonia/src/Consolonia.PlatformSupport/PlatformSupportExtensions.cs(75,66)
|
|
Inspect code:
src/Consolonia.PlatformSupport/Clipboard/MacOSXClipboard.cs#L43
"[CA2201] Exception type System.Exception is not sufficiently specific" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.PlatformSupport/Clipboard/MacOSXClipboard.cs(43,23)
|
|
Inspect code:
src/Consolonia.PlatformSupport/Clipboard/WSLClipboard.cs#L50
"[CSharpWarnings::CS1998] This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread." on /home/runner/work/Consolonia/Consolonia/src/Consolonia.PlatformSupport/Clipboard/WSLClipboard.cs(50,16)
|
|
Inspect code:
src/Consolonia.PlatformSupport/Clipboard/XClipClipboard.cs#L48
"[CSharpWarnings::CS1998] This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread." on /home/runner/work/Consolonia/Consolonia/src/Consolonia.PlatformSupport/Clipboard/XClipClipboard.cs(48,16)
|
|
Inspect code:
src/Consolonia.PlatformSupport/PlatformSupportExtensions.cs#L70
"[InconsistentNaming] Name 'IsWSLPlatform' does not match rule 'Methods'. Suggested name is 'IsWslPlatform'." on /home/runner/work/Consolonia/Consolonia/src/Consolonia.PlatformSupport/PlatformSupportExtensions.cs(70,29)
|
|
Inspect code:
src/Consolonia.PlatformSupport/Clipboard/MacOSXClipboard.cs#L13
"[InconsistentNaming] Name 'MacOSXClipboard' does not match rule 'Types and namespaces'. Suggested name is 'MacOsxClipboard'." on /home/runner/work/Consolonia/Consolonia/src/Consolonia.PlatformSupport/Clipboard/MacOSXClipboard.cs(13,20)
|
|
Inspect code:
src/Consolonia.PlatformSupport/Clipboard/WSLClipboard.cs#L13
"[InconsistentNaming] Name 'WSLClipboard' does not match rule 'Types and namespaces'. Suggested name is 'WslClipboard'." on /home/runner/work/Consolonia/Consolonia/src/Consolonia.PlatformSupport/Clipboard/WSLClipboard.cs(13,20)
|
|
Inspect code:
src/Consolonia.Core/Controls/LineStyles.cs#L38
"[AutoPropertyCanBeMadeGetOnly.Global] Auto-property can be made get-only" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/LineStyles.cs(38,38)
|
|
Inspect code:
src/Consolonia.Core/Controls/LineStyles.cs#L39
"[AutoPropertyCanBeMadeGetOnly.Global] Auto-property can be made get-only" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/LineStyles.cs(39,37)
|
|
Inspect code:
src/Consolonia.Core/Controls/LineStyles.cs#L40
"[AutoPropertyCanBeMadeGetOnly.Global] Auto-property can be made get-only" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/LineStyles.cs(40,39)
|
|
Inspect code:
src/Consolonia.Core/Controls/LineStyles.cs#L41
"[AutoPropertyCanBeMadeGetOnly.Global] Auto-property can be made get-only" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Controls/LineStyles.cs(41,40)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/DrawingBoxSymbol.cs#L26
"[AutoPropertyCanBeMadeGetOnly.Global] Auto-property can be made get-only" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/DrawingBoxSymbol.cs(26,44)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/EgaConsoleColor/EgaColor.cs#L30
"[AutoPropertyCanBeMadeGetOnly.Global] Auto-property can be made get-only" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/EgaConsoleColor/EgaColor.cs(30,42)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs#L86
"[AutoPropertyCanBeMadeGetOnly.Global] Auto-property can be made get-only" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs(86,36)
|
|
Inspect code:
src/Consolonia.Core/Drawing/PixelBufferImplementation/SimpleSymbol.cs#L46
"[AutoPropertyCanBeMadeGetOnly.Global] Auto-property can be made get-only" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/SimpleSymbol.cs(46,49)
|
|
Inspect code:
src/Tools/Consolonia.PreviewHost/ViewModels/ProjectViewModel.cs#L72
"[AutoPropertyCanBeMadeGetOnly.Global] Auto-property can be made get-only" on /home/runner/work/Consolonia/Consolonia/src/Tools/Consolonia.PreviewHost/ViewModels/ProjectViewModel.cs(72,41)
|
|
Inspect code:
src/Experimental/Consolonia.Designer/ConsolePreview.cs#L256
"[CA1859] Change return type of method 'RenderPixelBuffer' from 'Avalonia.Controls.Control' to 'Avalonia.Controls.StackPanel' for improved performance" on /home/runner/work/Consolonia/Consolonia/src/Experimental/Consolonia.Designer/ConsolePreview.cs(256,25)
|
Loading