Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify code in module importer #6077

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

postironix
Copy link
Contributor

improved cyclomatic difficulty from level C to level A in importer.py exit (checked with radon)

@JoanFM
Copy link
Member

JoanFM commented Oct 12, 2023

Hey @BouFFaNTCRiB ,

Could you have a detailed explanation of what is being fixed here? Is there any test that can be added?

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (8cea02a) 76.80% compared to head (f9619dd) 76.84%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6077      +/-   ##
==========================================
+ Coverage   76.80%   76.84%   +0.04%     
==========================================
  Files         145      145              
  Lines       13989    14005      +16     
==========================================
+ Hits        10744    10762      +18     
+ Misses       3245     3243       -2     
Flag Coverage Δ
jina 76.84% <82.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
jina/importer.py 89.32% <82.00%> (+1.96%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM changed the title refactoring_importer_exit refactor: simplify code in module importer Oct 18, 2023
@JoanFM JoanFM merged commit 9014308 into jina-ai:master Oct 18, 2023
126 of 129 checks passed
@JoanFM JoanFM mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants