Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify custom directory for index files #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

uros-r
Copy link

@uros-r uros-r commented Jun 30, 2023

Further to #6:

  • index_file_dir can be optionally set at collection level; otherwise defaults to current dir per existing behaviour
  • a couple of tests added (tests can now use a TemporaryDirectory)

@uros-r
Copy link
Author

uros-r commented Jun 30, 2023

As an aside, now that index filenames are derived from the collection name (f"index_{name}.hnsw"), rather than being generated dynamically, it probably makes sense to stop using filename from dbHnswIndexConfig going forward.

I've not made that change in this PR. Happy to roll it in if it does make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant