Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for search dim mismatch #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

uros-r
Copy link

@uros-r uros-r commented Jun 25, 2023

... to prevent downstream memory / segfault issues.

With a clean hnsqlite Python 3.10 venv and latest project deps on a Mac, the TestCollection2.test_search_invalid test fails for me with either

Python(39103,0x10bba4600) malloc: Incorrect checksum for freed object 0x7fa668a7d508: probably modified after being freed. Corrupt value: 0x8000000000000000

or occasionally an outright segmentation fault.

This PR adds a simple dim mismatch check in Collection.search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant