Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First stab at refactoring to use the new built in artifact-url output #46

Open
wants to merge 1 commit into
base: cansavvy/update
Choose a base branch
from

Conversation

acoffman
Copy link
Collaborator

@acoffman acoffman commented Feb 18, 2025

Hi @cansavvy,

I was working on porting the code here: https://github.com/orgs/community/discussions/51403#discussioncomment-5515349 to a generic, reusable action which led me to reading the docs for actions/upload-artifact as the version listed in the discussion answer is deprecated.

It turns out that, based on the release notes and the documented outputs, the artifact URL is now available directly as an output of the upload-artifact action.

This PR is a first stab at refactoring your refactor (in #44) to utilize this fact.

Now the primary action handles generating the reports, uploading them as artifacts, and managing the comments all in one workflow. There shouldn't be a need for the secondary commenter workflow or the API manipulation any longer.

Let me know if you think this makes sense and is the proper direction to take this workflow. If so, I need to do some more cleanup and testing and can go ahead and update the docs as part of this PR as well. (I just didn't want to go too far down this road if you think its the wrong way).

@cansavvy
Copy link
Contributor

This looks great! Thanks for getting this going. So glad to hear they've added this functionality! Let's make this something we can test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants