Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More data viz polishings! #544

Merged
merged 16 commits into from
Mar 20, 2024
Merged

More data viz polishings! #544

merged 16 commits into from
Mar 20, 2024

Conversation

cansavvy
Copy link
Contributor

@cansavvy cansavvy commented Mar 13, 2024

Summary

This is stacked on to #542 Because I wanted to chunk up the changes

This addresses the following from #530

  • adding a slide before tips to show that we are now talking about tips and common issues might be good
  • maybe we can remove the linetype from the plots until we get to introducing it

I just added a line that explains it. See how you feel about that strategy.

  • mention ThemePark maybe in the lecture
  • revisit slide before axis limits with xlim() and ylim()- do we need that there now?
  • add a tip that you need to run the name of your plot to see it - someone got confused about this
  • add that you can use numbers for linetype too
    Lab
  • add themepark to show fun themes :) https://matthewbjane.com/ThemePark/ - need to tell people how to install
  • add tip about using theme(legend.position = "none") for the last bonus in the lab - not sure what my last issue was saying about this- maybe I had already fixed it but I think a bigger tip might be helpful. or actually maybe it is best to leave it out but provide tips on how to find the documentation to figure it out
    [x] get rid of mapping= aes.. throughout? We weren't using it consistently

I wasn't really sure what these ones mean from that issue so they are not yet addressed:

  • for final question (not bonus) see what facet looks like with and without geom_point() - should lose a value for one of the facets and it will be empty
  • explain what groups are doing some more in the lecture - splitting up a line where multiple values are being plotted etc.

@cansavvy cansavvy mentioned this pull request Mar 13, 2024
9 tasks
Copy link
Contributor

github-actions bot commented Mar 13, 2024

No spelling errors! 🎉
Comment updated at 2024-03-20-03:41:02 with changes from 737d9a8

@cansavvy cansavvy changed the title Cansavvy/more data viz More data viz polishings! Mar 13, 2024
@cansavvy
Copy link
Contributor Author

This https://github.com/jhudsl/intro_to_r/pull/546/files needs to be tested and merged first. Then the docker image needs to be updated.

Copy link
Contributor

github-actions bot commented Mar 13, 2024

No broken URLs detected! 🎉
Comment updated at 2024-03-14 with changes from 01793cd

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

html files shouldn't be committed (similar to OTTR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay cool. Its this stuff I wasn't sure about the proper contributing etiquette on this repo. 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course! Should be more clear with updates to the contributing guide in #551 ❤️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH Noice.

Copy link
Contributor

github-actions bot commented Mar 15, 2024

No broken url errors! 🎉
Comment updated at 2024-03-20-03:40:55 with changes from 737d9a8

Copy link
Contributor

github-actions bot commented Mar 16, 2024

Re-rendered previews from the latest commit: See preview of website here

Updated at 2024-03-20 with changes from 737d9a8

@avahoffman
Copy link
Collaborator

Apologies for intruding - wanted to help get this caught up, especially given you've been bogged down.

Added question to address the second to last to do above. The last one is something that is already done, but could perhaps be improved. I think we are okay skipping that.

This is ready to go!

This was linked to issues Mar 20, 2024
@cansavvy
Copy link
Contributor Author

Apologies for intruding - wanted to help get this caught up, especially given you've been bogged down.

Oh no need for apologies. My feeling is one of relief -- my toes feel completely step free.

Happy to just continue to tee things up while you do the running into home. No problem by me if this is what you find helpful!

@avahoffman avahoffman merged commit 16d0d0a into main Mar 20, 2024
8 checks passed
@avahoffman avahoffman deleted the cansavvy/more-data-viz branch March 20, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThemePark added to jhudsl/intro_to_r:1.1 data viz updates
2 participants