-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More data viz polishings! #544
Conversation
No spelling errors! 🎉 |
This https://github.com/jhudsl/intro_to_r/pull/546/files needs to be tested and merged first. Then the docker image needs to be updated. |
No broken URLs detected! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
html files shouldn't be committed (similar to OTTR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay cool. Its this stuff I wasn't sure about the proper contributing etiquette on this repo. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course! Should be more clear with updates to the contributing guide in #551 ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OH Noice.
No broken url errors! 🎉 |
Re-rendered previews from the latest commit: See preview of website here Updated at 2024-03-20 with changes from 737d9a8 |
…tro_to_r into cansavvy/more-data-viz
Apologies for intruding - wanted to help get this caught up, especially given you've been bogged down. Added question to address the second to last to do above. The last one is something that is already done, but could perhaps be improved. I think we are okay skipping that. This is ready to go! |
Oh no need for apologies. My feeling is one of relief -- my toes feel completely step free. Happy to just continue to tee things up while you do the running into home. No problem by me if this is what you find helpful! |
Summary
This is stacked on to #542 Because I wanted to chunk up the changes
This addresses the following from #530
I just added a line that explains it. See how you feel about that strategy.
I wasn't really sure what these ones mean from that issue so they are not yet addressed: