remove unneeded OTTR scripts #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No spelling errors! 🎉 |
|
No broken url errors! 🎉 |
|
Re-rendered previews from the latest commit:
* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea. Updated at 2025-01-23 with changes from the latest commit 18d41cc |
|
@avahoffman any objections? any additional complication I might have missed? I think |
avahoffman
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm about to start working through #227 to get our existing repos up to date, and thought this would be a good time to do a bit of clean up.
Currently the scripts directory contains:
AnVIL_Feedback_Script.sh: we actively use, and want to keep syncinggit_repo_check.R: no longer in OTTR_Template, functionality now provided byottrpalmake_screenshots.R: no longer in OTTR_Template, functionality now provided byottr-reportsottr-fy.R: no longer in OTTR_Template, functionality now provided byottr-reportsThis PR:
1. Deletes unnecessary OTTR files
2. Moves
AnVIL_Feedback_Script.shI'm wondering if we want to move
AnVIL_Feedback_Script.shto.github/AnVIL_Feedback_Script.sh? We can then delete the scripts folder since OTTR no longer uses it. That lets us remove some clutter from the top-level directory by hiding away some backend functionality.3. Rerenders book
Adds a newline so that the book will rerender when this is merged to main and we can confirm everything is working as expected.
The pull-request jobs look like they ran without error.