Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to dio 5.0.1 #241

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ dependencies:
sdk: flutter
path_provider: ^2.0.1
path_provider_macos: ^2.0.0
dio: ^4.0.0
dio: ^5.0.1
permission_handler: ^8.1.4+2
flutter_local_notifications: ^9.0.0

Expand Down
1 change: 1 addition & 0 deletions lib/core/catcher.dart
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,7 @@ class Catcher with ReportModeAction {
_logger.warning(
"Error occurred in ${reportHandler.toString()}: ${handlerError.toString()}",
);
return true;
}).then((result) {
_logger.info("${report.runtimeType} result: $result");
if (!result) {
Expand Down
8 changes: 4 additions & 4 deletions lib/handlers/http_handler.dart
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ class HttpHandler extends ReportHandler {
final HttpRequestType requestType;
final Uri endpointUri;
final Map<String, dynamic> headers;
final int requestTimeout;
final int responseTimeout;
final Duration requestTimeout;
final Duration responseTimeout;
final bool printLogs;
final bool enableDeviceParameters;
final bool enableApplicationParameters;
Expand All @@ -26,8 +26,8 @@ class HttpHandler extends ReportHandler {
this.requestType,
this.endpointUri, {
Map<String, dynamic>? headers,
this.requestTimeout = 5000,
this.responseTimeout = 5000,
this.requestTimeout = const Duration(milliseconds: 5000),
this.responseTimeout = const Duration(milliseconds: 5000),
this.printLogs = false,
this.enableDeviceParameters = true,
this.enableApplicationParameters = true,
Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ dependencies:
device_info_plus_platform_interface: ^6.0.0
package_info_plus: ^3.0.0
mailer: ^5.0.2
dio: ^4.0.1
dio: ^5.0.1
flutter_mailer: ^2.0.0
logging: ^1.0.2
sentry: ^6.1.0
sentry: ^7.4.2
universal_io: ^2.0.4

dev_dependencies:
Expand Down