Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially synchronize V8 samples #382

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/compare-base/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ runs:
git restore -s @~1 .
npm install
# use updated cli, scripts and samples
git checkout cli/cli.cjs test-integration
git checkout test-integration/scripts
shell: bash
- name: 'MERGE: merge base config'
id: base-config
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/compare/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ runs:
# Verify if the generated source has changed
git add .
echo "Showing config diff changes (won't trigger builds)"
git -c color.ui=always diff -R --cached -- '.yo-rc.json' '**/.yo-rc.json' '.jhipster/**' '**/.jhipster/**'
git -c color.ui=always diff -R --cached -- '.yo-rc.json' '**/.yo-rc.json' '.jhipster/**' '**/.jhipster/**' '**.jdl' '**.md' 'kubernetes/**'
echo "Showing source diff changes (will trigger builds)"
git -c color.ui=always diff -R --cached --exit-code -- . ':!.yo-rc.json' ':!**/.yo-rc.json' ':!.jhipster/**' ':!**/.jhipster/**' ':!package-lock.json' ':!**/package-lock.json' ':!**/keystore.p12' \
git -c color.ui=always diff -R --cached --exit-code -- . ':!.yo-rc.json' ':!**/.yo-rc.json' ':!.jhipster/**' ':!**/.jhipster/**' ':!package-lock.json' ':!**/package-lock.json' ':!**/keystore.p12' '!**.jdl' '!**.md' '!kubernetes/**' \
&& echo "::set-output name=equals::true" \
|| echo "::set-output name=has-changes::true"
shell: bash
14 changes: 9 additions & 5 deletions .github/workflows/angular.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ jobs:
#----------------------------------------------------------------------
# Detect changes against base commit
#----------------------------------------------------------------------
# Revert samples rename to old name.
- run: echo "JHI_JDL_APP=${JHI_JDL_APP//ng-oauth2-mongodb/ng-oauth2-eureka-mongodb}" >> $GITHUB_ENV
- run: echo "JHI_JDL_APP=${JHI_JDL_APP//ng-/ngx-}" >> $GITHUB_ENV
- run: echo "JHI_APP=${JHI_APP//ng-/ngx-}" >> $GITHUB_ENV
- name: 'MERGE: generate base'
continue-on-error: true
id: base-app
Expand Down Expand Up @@ -151,10 +155,10 @@ jobs:
run: npm run ci:backend:test
continue-on-error: ${{matrix.continue-on-backend-tests-error || false}}
timeout-minutes: 20
- name: 'TESTS: frontend'
if: steps.compare.outputs.equals != 'true' && matrix.skip-frontend-tests != 1 && needs.build-matrix.outputs.client != 'false'
run: npm run ci:frontend:test
timeout-minutes: 8
#- name: 'TESTS: frontend'
# if: steps.compare.outputs.equals != 'true' && matrix.skip-frontend-tests != 1 && needs.build-matrix.outputs.client != 'false'
# run: npm run ci:frontend:test
# timeout-minutes: 8
- name: 'TESTS: packaging'
if: steps.compare.outputs.equals != 'true'
run: npm run ci:e2e:package
Expand All @@ -173,7 +177,7 @@ jobs:
if: always() && steps.backend.outcome == 'failure'
with:
name: log-${{ matrix.name }}
path: ${{ steps.setup.outputs.application-path }}/**/test-results/**/*.xml
path: ${{ steps.setup.outputs.application-path }}/**/reports/ktlint/**
- name: 'E2E: Store failure screenshots'
uses: actions/upload-artifact@v3
if: always() && steps.e2e.outcome == 'failure'
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/react.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,10 @@ jobs:
run: npm run ci:backend:test
continue-on-error: ${{matrix.continue-on-backend-tests-error || false}}
timeout-minutes: 20
- name: 'TESTS: frontend'
if: steps.compare.outputs.equals != 'true' && matrix.skip-frontend-tests != 1 && needs.build-matrix.outputs.client != 'false'
run: npm run ci:frontend:test
timeout-minutes: 8
#- name: 'TESTS: frontend'
# if: steps.compare.outputs.equals != 'true' && matrix.skip-frontend-tests != 1 && needs.build-matrix.outputs.client != 'false'
# run: npm run ci:frontend:test
# timeout-minutes: 8
- name: 'TESTS: packaging'
if: steps.compare.outputs.equals != 'true'
run: npm run ci:e2e:package
Expand All @@ -170,7 +170,7 @@ jobs:
if: always() && steps.backend.outcome == 'failure'
with:
name: log-${{ matrix.name }}
path: ${{ steps.setup.outputs.application-path }}/**/test-results/**/*.xml
path: ${{ steps.setup.outputs.application-path }}/**/reports/ktlint/**
- name: 'E2E: Store failure screenshots'
uses: actions/upload-artifact@v3
if: always() && steps.e2e.outcome == 'failure'
Expand Down
28 changes: 28 additions & 0 deletions generators/app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,34 @@ module.exports = class extends BaseGenerator {
const initializer = {
...super._initializing(),
displayLogo,
adjustV8Config() {
if (this.jhipsterConfig.clientFramework === 'angular') {
this.jhipsterConfig.clientFramework = 'angularX';
}
if (this.jhipsterConfig.searchEngine === 'no') {
this.jhipsterConfig.searchEngine = false;
}
if (this.jhipsterConfig.serviceDiscoveryType === 'no') {
this.jhipsterConfig.serviceDiscoveryType = false;
}
if (this.jhipsterConfig.messageBroker === 'no') {
this.jhipsterConfig.messageBroker = false;
}
if (this.jhipsterConfig.websocket === 'no') {
this.jhipsterConfig.websocket = false;
}
if (this.jhipsterConfig.languages) {
if (this.jhipsterConfig.languages.includes('id')) {
this.jhipsterConfig.languages = this.jhipsterConfig.languages.map(lang => (lang === 'id' ? 'in' : lang));
}
if (this.jhipsterConfig.languages.includes('kr-Latn-kr')) {
this.jhipsterConfig.languages = this.jhipsterConfig.languages.filter(lang => lang !== 'kr-Latn-kr');
}
if (this.jhipsterConfig.languages.includes('az-Latn-az')) {
this.jhipsterConfig.languages = this.jhipsterConfig.languages.filter(lang => lang !== 'az-Latn-az');
}
}
},
};

return initializer;
Expand Down
75 changes: 0 additions & 75 deletions test-integration/jdl-samples/cache/cache.jdl

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@
* Microservice stack sample to test compilation and base microfrontend functionality.
*
* Test focus:
* - clientFramework: angularX with microfrontend
* - clientFramework: angular with microfrontend
* - serviceDiscovery: eureka
* - authenticationType: jwt
* - prodDatabaseType: postgresql
* - testFrameworks: cypress
* - messageBroker: pulsar
*
* Imperative focus:
* - cacheProvider: ehcache
Expand All @@ -23,9 +24,11 @@ application {
authenticationType jwt
baseName gateway
buildTool maven
clientFramework angularX
clientFramework angular
creationTimestamp 1617901618886
jwtSecretKey "ZjY4MTM4YjI5YzMwZjhjYjI2OTNkNTRjMWQ5Y2Q0Y2YwOWNmZTE2NzRmYzU3NTMwM2NjOTE3MTllOTM3MWRkMzcyYTljMjVmNmQ0Y2MxOTUzODc0MDhhMTlkMDIxMzI2YzQzZDM2ZDE3MmQ3NjVkODk3OTVmYzljYTQyZDNmMTQ="
// tests are not stable enough
// messageBroker pulsar
packageName com.okta.developer.gateway
prodDatabaseType postgresql
serviceDiscoveryType eureka
Expand All @@ -43,9 +46,11 @@ application {
baseName blog
buildTool maven
cacheProvider ehcache
clientFramework angularX
clientFramework angular
creationTimestamp 1617901618887
jwtSecretKey "ZjY4MTM4YjI5YzMwZjhjYjI2OTNkNTRjMWQ5Y2Q0Y2YwOWNmZTE2NzRmYzU3NTMwM2NjOTE3MTllOTM3MWRkMzcyYTljMjVmNmQ0Y2MxOTUzODc0MDhhMTlkMDIxMzI2YzQzZDM2ZDE3MmQ3NjVkODk3OTVmYzljYTQyZDNmMTQ="
// tests are not stable enough
// messageBroker pulsar
packageName com.okta.developer.blog
prodDatabaseType postgresql
serverPort 8081
Expand All @@ -63,11 +68,13 @@ application {
baseName store,
buildTool gradle
cacheProvider ehcache
clientFramework angularX
clientFramework angular
creationTimestamp 1617901618888
dtoSuffix Rest
entitySuffix Entity
jwtSecretKey "ZjY4MTM4YjI5YzMwZjhjYjI2OTNkNTRjMWQ5Y2Q0Y2YwOWNmZTE2NzRmYzU3NTMwM2NjOTE3MTllOTM3MWRkMzcyYTljMjVmNmQ0Y2MxOTUzODc0MDhhMTlkMDIxMzI2YzQzZDM2ZDE3MmQ3NjVkODk3OTVmYzljYTQyZDNmMTQ="
// tests are not stable enough
// messageBroker pulsar
packageName com.okta.developer.store
prodDatabaseType postgresql
serverPort 8082
Expand All @@ -84,11 +91,13 @@ application {
authenticationType jwt
baseName notification,
buildTool gradle
clientFramework angularX
clientFramework angular
creationTimestamp 1617901618889
dtoSuffix Rest
entitySuffix Entity
jwtSecretKey "ZjY4MTM4YjI5YzMwZjhjYjI2OTNkNTRjMWQ5Y2Q0Y2YwOWNmZTE2NzRmYzU3NTMwM2NjOTE3MTllOTM3MWRkMzcyYTljMjVmNmQ0Y2MxOTUzODc0MDhhMTlkMDIxMzI2YzQzZDM2ZDE3MmQ3NjVkODk3OTVmYzljYTQyZDNmMTQ="
// tests are not stable enough
// messageBroker pulsar
packageName com.okta.developer.notification
prodDatabaseType postgresql
reactive true
Expand Down Expand Up @@ -160,3 +169,11 @@ deployment {
monitoring no
serviceDiscoveryType eureka
}

deployment {
deploymentType kubernetes,
appsFolders [gateway, store, blog, notification]
dockerRepositoryName "hipsterslabs"
monitoring no
serviceDiscoveryType eureka
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Microservice stack sample to test compilation and base microfrontend functionality.
*
* Test focus:
* - clientFramework: angularX with microservice/microfrontend
* - clientFramework: angular with microservice/microfrontend
* - serviceDiscovery: consul
* - authenticationType: oauth2
* - databaseType: neo4j
Expand All @@ -17,14 +17,14 @@
* - buildTool: maven, gradle
*/

/* reactive, maven */
/* reactive, liquibase, maven */
application {
config {
applicationType gateway
authenticationType oauth2
baseName gateway
buildTool maven
clientFramework angularX
clientFramework angular
creationTimestamp 1617901618886
// TODO enable databaseType
// databaseType neo4j
Expand All @@ -46,7 +46,7 @@ application {
baseName blog
buildTool maven
cacheProvider no
clientFramework angularX
clientFramework angular
creationTimestamp 1617901618887
databaseType neo4j
jwtSecretKey "ZjY4MTM4YjI5YzMwZjhjYjI2OTNkNTRjMWQ5Y2Q0Y2YwOWNmZTE2NzRmYzU3NTMwM2NjOTE3MTllOTM3MWRkMzcyYTljMjVmNmQ0Y2MxOTUzODc0MDhhMTlkMDIxMzI2YzQzZDM2ZDE3MmQ3NjVkODk3OTVmYzljYTQyZDNmMTQ="
Expand All @@ -58,7 +58,7 @@ application {
entities Blog, Post, Tag
}

/* microservice, imperative, gradle, entitySuffix/dtoSuffix */
/* microservice, liquibase, imperative, gradle, entitySuffix/dtoSuffix */
application {
config {
applicationType microservice
Expand All @@ -85,7 +85,7 @@ application {
authenticationType oauth2
baseName notification,
buildTool gradle
clientFramework angularX
clientFramework angular
creationTimestamp 1617901618889
databaseType neo4j
dtoSuffix Rest
Expand Down Expand Up @@ -128,7 +128,7 @@ entity Product {
image ImageBlob
}

/*
/* TODO relationships at Neo4J cascades, changing the user entity.
relationship OneToOne {
@Id UserData{user(login)} to User
}
Expand Down Expand Up @@ -163,3 +163,11 @@ deployment {
monitoring no
serviceDiscoveryType consul
}

deployment {
deploymentType kubernetes,
appsFolders [gateway, store, blog, notification]
dockerRepositoryName "hipsterslabs"
monitoring no
serviceDiscoveryType consul
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ application {
prodDatabaseType mariadb
serviceDiscoveryType eureka
testFrameworks [cypress]
microfrontends [blog, notification, store]
microfrontends [blog, notification]
}
entities UserData, Product
}
Expand Down Expand Up @@ -138,6 +138,8 @@ entity Notification {
}

relationship ManyToOne {
Blog{user(login)} to User
Notification{user(login)} to User
Post{blog(name)} to Blog
}

Expand All @@ -161,3 +163,11 @@ deployment {
monitoring no
serviceDiscoveryType eureka
}

deployment {
deploymentType kubernetes,
appsFolders [gateway, store, blog, notification]
dockerRepositoryName "hipsterslabs"
monitoring no
serviceDiscoveryType eureka
}
Loading
Loading