Improve colour loading versions of outlined buttons #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, this is how Schermopname.van.2025-01-24.12-16-01.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a ** improvement | bugfix **.
Right now the loading version of outlined buttons is broken for
is-link, the other versions have been downgraded from from 0.x (in my opinion)Proposed solution
Overwrite the
loading-colorvariable on buttons with theis-outlinedmodifierTradeoffs
I'm new to the whole variable thing, but I hope overwriting a variable in a subclass is the way to go
Testing Done
I tested all variants by making temporary changes to the documentation files, with and without
[disabled]Changelog updated?
No.