Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New XSC analytics metrics capabilities. #928

Merged
merged 68 commits into from
Apr 3, 2024
Merged

New XSC analytics metrics capabilities. #928

merged 68 commits into from
Apr 3, 2024

Conversation

gailazar300
Copy link
Contributor

@gailazar300 gailazar300 commented Mar 26, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Add new XSC APIs for add & update & get analytics metrics general events.

gailazar300 and others added 30 commits December 29, 2021 14:59
@gailazar300
change branches
1b94940
@gailazar300
test
0df64cd
@gailazar300
all branches
1edfa13
@omerzi
Promote version to 1.28.1 (jfrog#733)
a664ea4
@eyalbe4
Added the Frogbot badge to the README (jfrog#740)
0b22cb3
@sverdlov93
Merge remote-tracking branch 'upstream/dev' into masterupstream
93d1ee0 
# Conflicts:
#	.github/workflows/analysis.yml
#	go.mod
#	go.sum
#	utils/utils.go
#	xray/services/scan.go
#	xray/services/scan_test.go
@omerzi
Merge remote-tracking branch 'origin/dev'
60012f0
@eyalbe4
Merge branch 'dev'
72340a7
@talarian1
Merge remote-tracking branch 'origin/dev'
3c0e410
@omerzi
Merge remote-tracking branch 'origin/dev'
7dd161b
@talarian1
Merge remote-tracking branch 'origin/dev'
88f4c5c
@yahavi
Merge branch 'master' into dev
21b99ad
@yahavi
Promoted version to 1.29.1
b71c280
@eyalbe4
Merge branch 'dev'
8f7755c
@eyalbe4
Merge branch 'dev'
e6ba583
@RobiNino
Merge branch 'dev'
b624428
@omerzi
Merge branch 'master' into dev
da0c018
@omerzi
Promoted version to 1.31.1
f750025
@omerzi
Merge remote-tracking branch 'origin/dev'
e1d57bd 
# Conflicts:
#	utils/utils.go
@eyalbe4
Merge branch 'dev'
886ff5f
@eyalbe4
Promoted version to 1.31.3
b1ae836
@eyalbe4
Merge branch 'dev'
df38e23
@eyalbe4
Merge branch 'dev'
46b7fb9
@eyalbe4
Resolve conflicts
5f58723
@eyalbe4
Merge branch 'dev'
080ef1a
@attiasas
Merge branch 'dev'
7c244c5
@EyalDelarea
Merge branch 'master' into dev
6d1c9e7
@EyalDelarea
Merge remote-tracking branch 'origin/dev'
b3d917f
@sverdlov93
Merge remote-tracking branch 'upstream/dev'
3be412b
@RobiNino
Merge branch 'dev'
fa697b5
@attiasas attiasas mentioned this pull request Apr 2, 2024
Merged
4 tasks
attiasas
attiasas suggested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change:
https://github.com/jfrog/jfrog-client-go/blob/master/.github/workflows/tests.yml
add the new test suite xsc and pass the new creds you added.
Right now the tests will never run. In addition, add option to skip the tests if the Xsc is not enabled for the platform

xsc/services/analyticsevent.go Outdated Show resolved Hide resolved
xsc/services/analyticsevent.go Outdated Show resolved Hide resolved
xsc/services/analyticsevent.go Outdated Show resolved Hide resolved
xsc/auth/xscdetails.go Show resolved Hide resolved
tests/xscanalyticsevent_test.go Show resolved Hide resolved
tests/xscanalyticsevent_test.go Show resolved Hide resolved
tests/utils_test.go Outdated Show resolved Hide resolved
@attiasas attiasas mentioned this pull request Apr 2, 2024
Merged
6 tasks
@attiasas attiasas added the new feature Automatically generated release notes label Apr 2, 2024
@attiasas
Copy link
Contributor

attiasas commented Apr 2, 2024

Please, update the README with documentation about the new API

@gailazar300 gailazar300 added the safe to test Approve running integration tests on a pull request label Apr 2, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 2, 2024
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Apr 2, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 2, 2024
eyalbe4
eyalbe4 requested changes Apr 2, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
xsc/services/analyticsevent.go Outdated Show resolved Hide resolved
@eyalbe4 eyalbe4 changed the title Add XSC analytics metrics capabilities. New XSC analytics metrics capabilities. Apr 2, 2024
@gailazar300 gailazar300 added the safe to test Approve running integration tests on a pull request label Apr 2, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

eyalbe4
eyalbe4 requested changes Apr 2, 2024
View reviewed changes
utils/utils.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@eyalbe4 eyalbe4 added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request and removed new feature Automatically generated release notes labels Apr 3, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 3, 2024
@eyalbe4 eyalbe4 merged commit 8292671 into jfrog:dev Apr 3, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranturgeman eranturgeman eranturgeman left review comments

@attiasas attiasas attiasas requested changes

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@gailazar300 @attiasas @eyalbe4 @eranturgeman @omerzi @sverdlov93 @talarian1 @yahavi @RobiNino @EyalDelarea