Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifactory Release Lifecycle Management - Support release bundle distribution by project #913

Merged
merged 7 commits into from
Mar 18, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'dev' of https://github.com/jfrog/jfrog-client-go into r…
…bv2-ds-proj

# Conflicts:
#	lifecycle/services/delete.go
RobiNino committed Mar 18, 2024
commit 9da34ad9295d1f759ac4d2fb238c0087c6bdae40
12 changes: 11 additions & 1 deletion lifecycle/services/delete.go
Original file line number Diff line number Diff line change
@@ -19,7 +19,17 @@ const (
remoteDeleteEndpoint = "remote_delete"
)

func (rbs *ReleaseBundlesService) DeleteReleaseBundle(rbDetails ReleaseBundleDetails, params CommonOptionalQueryParams) error {
func (rbs *ReleaseBundlesService) DeleteReleaseBundleVersion(rbDetails ReleaseBundleDetails, params CommonOptionalQueryParams) error {
restApi := path.Join(releaseBundleBaseApi, records, rbDetails.ReleaseBundleName, rbDetails.ReleaseBundleVersion)
return rbs.deleteReleaseBundle(params, restApi)
}

func (rbs *ReleaseBundlesService) DeleteReleaseBundleVersionPromotion(rbDetails ReleaseBundleDetails, params CommonOptionalQueryParams, createdMillis string) error {
restApi := path.Join(promotionBaseApi, records, rbDetails.ReleaseBundleName, rbDetails.ReleaseBundleVersion, createdMillis)
return rbs.deleteReleaseBundle(params, restApi)
}

func (rbs *ReleaseBundlesService) deleteReleaseBundle(params CommonOptionalQueryParams, restApi string) error {
queryParams := distribution.GetProjectQueryParam(params.ProjectKey)
queryParams[async] = strconv.FormatBool(params.Async)
requestFullUrl, err := utils.BuildUrl(rbs.GetLifecycleDetails().GetUrl(), restApi, queryParams)
You are viewing a condensed version of this merge commit. You can view the full changes here.