Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifactory Release Lifecycle Management - Support release bundles deletion #911

Merged
merged 3 commits into from
Mar 17, 2024

Conversation

RobiNino
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@RobiNino RobiNino added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes labels Feb 25, 2024
@RobiNino RobiNino requested review from eyalbe4 and yahavi February 25, 2024 13:36
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 25, 2024
lifecycle/services/delete.go Outdated Show resolved Hide resolved
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add GetReleaseBundleVersionPromotions, DeleteReleaseBundleVersion and DeleteReleaseBundleVersionPromotion to the README.

Also, please add some unit tests.

lifecycle/services/delete.go Show resolved Hide resolved
lifecycle/services/distribute.go Show resolved Hide resolved
lifecycle/services/promote.go Show resolved Hide resolved
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Mar 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 14, 2024
@RobiNino RobiNino merged commit e419c2a into jfrog:dev Mar 17, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants