Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build promotion missing url encoding issue #894

Closed
wants to merge 1 commit into from
Closed

Fix build promotion missing url encoding issue #894

wants to merge 1 commit into from

Conversation

sverdlov93
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

should fix jfrog/jfrog-cli#2426

@sverdlov93
fix bp
6898950 
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 changed the base branch from master to dev January 31, 2024 16:43
@sverdlov93 sverdlov93 requested a review from eyalbe4 January 31, 2024 16:43
@sverdlov93 sverdlov93 added the bug Something isn't working label Jan 31, 2024
@sverdlov93 sverdlov93 requested a review from yahavi January 31, 2024 16:43
@sverdlov93 sverdlov93 mentioned this pull request Jan 31, 2024
Open
@sverdlov93 sverdlov93 changed the title Fix build promote missing url encoding for build name and number Fix build promotion missing url encoding issue Jan 31, 2024
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jan 31, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 31, 2024
@sverdlov93 sverdlov93 closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"/" in build number will cause the build promotion to fail
1 participant
@sverdlov93