Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry HTTP requests when receiving 429 #862

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Retry HTTP requests when receiving 429 #862

merged 1 commit into from
Nov 20, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 15, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

HTTP responses might come back with a 429 error code, indicating "Too many requests." To help the client handle these errors better, we could enable retries.

@yahavi yahavi added the improvement Automatically generated release notes label Nov 15, 2023
@yahavi yahavi requested a review from eyalbe4 November 15, 2023 09:54
@yahavi yahavi self-assigned this Nov 15, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Nov 15, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 15, 2023
@yahavi yahavi merged commit a4c0557 into jfrog:dev Nov 20, 2023
23 of 24 checks passed
@yahavi yahavi deleted the too-many branch November 20, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4