Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support overall request timeout in all services #837

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Support overall request timeout in all services #837

merged 3 commits into from
Oct 3, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 3, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Rename HttpTimeout -> DialTimeout.
  • Allow configuring "OverallRequestTimeout" to all requests. This timeout is the total time between the request and the response. It has no timeout by default.

@yahavi yahavi added the new feature Automatically generated release notes label Oct 3, 2023
@yahavi yahavi requested a review from eyalbe4 October 3, 2023 08:59
@yahavi yahavi self-assigned this Oct 3, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 3, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 3, 2023
eyalbe4
eyalbe4 requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update the documentation at - https://github.com/jfrog/documentation/blob/main/jfrog-applications/ci-and-sdks/sdks/jfrog-go-client.md

config/configbuilder.go Outdated Show resolved Hide resolved
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 3, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 3, 2023
@yahavi yahavi merged commit 90e9d7e into jfrog:dev Oct 3, 2023
@yahavi yahavi deleted the timeout branch October 3, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees

@yahavi yahavi

Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4