Introducing Workspaces into pipelines #793
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| package services | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "errors" | ||
|
Check failure on line 5 in pipelines/services/validate.go
|
||
| "github.com/gookit/color" | ||
| "github.com/jfrog/jfrog-client-go/auth" | ||
| "github.com/jfrog/jfrog-client-go/http/jfroghttpclient" | ||
| "github.com/jfrog/jfrog-client-go/utils/errorutils" | ||
| "github.com/jfrog/jfrog-client-go/utils/io/httputils" | ||
| "github.com/jfrog/jfrog-client-go/utils/log" | ||
| "net/http" | ||
| "net/url" | ||
| "strconv" | ||
| ) | ||
|
|
||
| const ( | ||
| validatePipResourcePath = "api/v1/validateYaml" | ||
| ) | ||
|
|
||
| type ValidateService struct { | ||
| client *jfroghttpclient.JfrogHttpClient | ||
| auth.ServiceDetails | ||
| } | ||
|
|
||
| func NewValidateService(client *jfroghttpclient.JfrogHttpClient) *ValidateService { | ||
| return &ValidateService{client: client} | ||
| } | ||
|
|
||
| func (vs *ValidateService) getHttpDetails() httputils.HttpClientDetails { | ||
| httpDetails := vs.CreateHttpClientDetails() | ||
| return httpDetails | ||
| } | ||
|
|
||
| func (vs *ValidateService) ValidatePipeline(data []byte) error { | ||
| var err error | ||
| httpDetails := vs.getHttpDetails() | ||
|
|
||
| // Query params | ||
| m := make(map[string]string, 0) | ||
|
|
||
|
|
||
| // URL Construction | ||
| uri := vs.constructValidateAPIURL(m, validatePipResourcePath) | ||
|
|
||
| // Headers | ||
| headers := make(map[string]string) | ||
| utils.SetContentType("application/json", &headers) | ||
|
Check failure on line 47 in pipelines/services/validate.go
|
||
| httpDetails.Headers = headers | ||
|
|
||
| // Send post request | ||
| resp, body, err := vs.client.SendPost(uri, data, &httpDetails) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if err := errorutils.CheckResponseStatusWithBody(resp, body, http.StatusOK); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // Process response | ||
| if nil != resp && resp.StatusCode == http.StatusOK { | ||
| log.Info("Processing resources yaml response ") | ||
| log.Info(string(body)) | ||
| err = processValidatePipResourceResponse(body) | ||
| if err != nil { | ||
| log.Error("Failed to process resources validation response") | ||
| } | ||
| } | ||
|
Comment on lines
+60
to
+67
There was a problem hiding this comment. You already check the status code in CheckResponseStatusWithBody. Please also consider nil before "CheckResponseStatusWithBody". |
||
| return nil | ||
| } | ||
|
|
||
| // processValidatePipResourceResponse process validate pipeline resource response | ||
| func processValidatePipResourceResponse(resp []byte) error { | ||
| validationResponse := make(map[string]ValidationResponse) | ||
| err := json.Unmarshal(resp, &validationResponse) | ||
| if err != nil { | ||
| return errorutils.CheckError(err) | ||
| } | ||
| if len(validationResponse) == 0 { | ||
| return errorutils.CheckErrorf("pipelines not found") | ||
| } | ||
| for k, v := range validationResponse { | ||
| if v.IsValid != nil && *v.IsValid { | ||
| log.Info("Validation of pipeline resources completed successfully") | ||
| msg := color.Green.Sprintf("Validation completed") | ||
| log.Info(msg) | ||
| } else { | ||
| fileName := color.Red.Sprintf("%s", k) | ||
| log.Error(fileName) | ||
| validationErrors := v.Errors | ||
| for _, validationError := range validationErrors { | ||
| lineNum := validationError.LineNumber | ||
| errorMessage := color.Red.Sprintf("%s", validationError.Text+":"+strconv.Itoa(lineNum)) | ||
| log.Error(errorMessage) | ||
| } | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| // constructPipelinesURL creates URL with all required details to make api call | ||
| // like headers, queryParams, apiPath | ||
| func (vs *ValidateService) constructValidateAPIURL(qParams map[string]string, apiPath string) string { | ||
| uri, err := url.Parse(vs.ServiceDetails.GetUrl() + apiPath) | ||
| if err != nil { | ||
| log.Error("Failed to parse pipelines fetch run status url") | ||
|
|
||
| } | ||
|
|
||
| queryString := uri.Query() | ||
| for k, v := range qParams { | ||
| queryString.Set(k, v) | ||
| } | ||
| uri.RawQuery = queryString.Encode() | ||
|
|
||
| return uri.String() | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this login be inside workspaceService.GetWorkspacePipelines? Let's try to keep the manager clean.