Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New report scan of licenses and violations #775

Merged
merged 27 commits into from
Sep 4, 2023
Merged

New report scan of licenses and violations #775

merged 27 commits into from
Sep 4, 2023

Conversation

ns-dsinghal
Copy link
Contributor

@ns-dsinghal ns-dsinghal commented May 24, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ns-dsinghal
Copy link
Contributor Author

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA

@ns-dsinghal
Copy link
Contributor Author

recheck

@ns-dsinghal ns-dsinghal marked this pull request as draft May 24, 2023 15:36
@ns-dsinghal ns-dsinghal marked this pull request as ready for review May 24, 2023 15:36
@ns-dsinghal
Copy link
Contributor Author

recheck
recheck

@ns-dsinghal
Copy link
Contributor Author

@talarian1 @eyalbe4

Can you Please review and merge this PR

@ns-kbhat
Copy link
Contributor

ns-kbhat commented May 25, 2023 •
edited
Loading

recheck

1 similar comment
@ns-kbhat
Copy link
Contributor

recheck

@ns-kbhat
Copy link
Contributor

@talarian1 @eyalbe4 can you please take a look at this? The CLA acceptance is not being re-checked.

@ns-kbhat
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA. Recheck

@ns-kbhat
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA. recheck

@yahavi yahavi added improvement Automatically generated release notes new feature Automatically generated release notes and removed improvement Automatically generated release notes labels May 30, 2023
yahavi
yahavi requested changes May 30, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, @ns-dsinghal!

Could you please document this change in the README?
Regarding the CLA assistant - it expects a comment containing exactly "I have read the CLA Document and I hereby sign the CLA". Could you please add such a comment?

Thanks.

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label May 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 30, 2023
@ns-dsinghal
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@ns-kbhat
Copy link
Contributor

@yahavi @eyalbe4 could you please review and merge this?

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Sep 1, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 1, 2023
@yahavi
Copy link
Member

yahavi commented Sep 1, 2023

@ns-kbhat @ns-dsinghal - could you please fix the static code analysis issues?

@ns-dsinghal
Copy link
Contributor Author

@ns-kbhat @ns-dsinghal - could you please fix the static code analysis issues?

Fixed and checked locally.

@ns-kbhat
Copy link
Contributor

ns-kbhat commented Sep 1, 2023

@ns-kbhat @ns-dsinghal - could you please fix the static code analysis issues?

Fixed and checked locally.

cc @yahavi @eyalbe4

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Sep 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 3, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Sep 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 3, 2023
@ns-kbhat
Copy link
Contributor

ns-kbhat commented Sep 4, 2023

@yahavi what is the next step here?

@yahavi yahavi changed the title adding report scan of License and violation type New report scan of Licenses and violations Sep 4, 2023
@yahavi yahavi changed the title New report scan of Licenses and violations New report scan of licenses and violations Sep 4, 2023
@yahavi yahavi merged commit f3f2a10 into jfrog:dev Sep 4, 2023
@yahavi
Copy link
Member

yahavi commented Sep 4, 2023

Thanks for your contribution, @ns-dsinghal & @ns-kbhat!
I merged the PR.
Please inform us if everything is functioning correctly.

@ns-kbhat
Copy link
Contributor

ns-kbhat commented Sep 5, 2023

@ns-dsinghal did all the work, so kudos to him.

@yahavi when can we expect this change to be rolled into a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ns-kbhat ns-kbhat ns-kbhat left review comments

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ns-dsinghal @ns-kbhat @yahavi @omerzi @eyalbe4 @sverdlov93 @talarian1 @RobiNino @attiasas