Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal API - Visibility System fix & improvements #1061

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Internal API - Visibility System fix & improvements #1061

merged 2 commits into from
Dec 22, 2024

Conversation

eyalbe4
Copy link
Contributor

@eyalbe4 eyalbe4 commented Dec 22, 2024

  • Fix the API endpoint.
  • Improve the API to accept a struct instead of a JSON

@eyalbe4 eyalbe4 added the bug Something isn't working label Dec 22, 2024
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Dec 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 22, 2024
@eyalbe4 eyalbe4 changed the base branch from master to dev December 22, 2024 15:23
@eyalbe4 eyalbe4 mentioned this pull request Dec 22, 2024
Merged
@eyalbe4 eyalbe4 requested a review from sverdlov93 December 22, 2024 15:33
sverdlov93
sverdlov93 reviewed Dec 22, 2024
View reviewed changes
jfconnect/manager.go Outdated Show resolved Hide resolved
@eyalbe4 eyalbe4 merged commit d77d8c8 into jfrog:dev Dec 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eyalbe4 @sverdlov93 @eyalb4doc