Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Maven tests #2841

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Fix Maven tests #2841

merged 7 commits into from
Jan 22, 2025

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Jan 22, 2025

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

This PR sets the fixed maven version of 3.8.8 to avoid unwanted upgrades.
Instead of only for macOS we now want for all images to run with a fixed version of maven until fixed.

Base images updated their maven version to 3.9.x which cause breaking changes.

actions/runner-images#11093

@EyalDelarea EyalDelarea marked this pull request as ready for review January 22, 2025 12:52
@EyalDelarea EyalDelarea added the ignore for release Automatically generated release notes label Jan 22, 2025
@EyalDelarea EyalDelarea merged commit 500aa75 into jfrog:dev Jan 22, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant