Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign MacOS Binaries with JFrog Certificate #2563

Merged
merged 236 commits into from
Jan 21, 2025

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Jun 3, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Sign Darwin Binaries during Release

This PR introduce a way to integrate darwin signed executables singing during the CLI release.

Darwin Release Flow:

flowchart TD

    A[Release Pipepline Triggers the MacOS specific workflow] --> B[GitHub Actions Build & Upload Signed darwin exeutables] --> C(Jenkins Job downloads the binary from Github packages)
    
    C --> E
    
   E[Distribute to releases]
    

Loading

Tested Jenkinsfile functions :
image
fixed all the syntax and interpolation issues

TODO Before merging:

  • Test Jenkins script
  • Add apple secrets to repository
  • Adjust download links in scripts repository
  • Add GitHub Token to Jenkins

@EyalDelarea EyalDelarea added the improvement Automatically generated release notes label Jun 3, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Jan 21, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 21, 2025
@EyalDelarea EyalDelarea merged commit 8eb19f6 into jfrog:dev Jan 21, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signed JFrog CLI binary for MacOS
2 participants