Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release script #2344

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Fix release script #2344

merged 1 commit into from
Dec 4, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Dec 4, 2023

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • Rename state -> stage
  • Config Git identity
  • Config push default

@yahavi yahavi added the ignore for release Automatically generated release notes label Dec 4, 2023
@yahavi yahavi requested a review from eyalbe4 December 4, 2023 14:58
@yahavi yahavi self-assigned this Dec 4, 2023
@yahavi yahavi merged commit 8b83bba into jfrog:dev Dec 4, 2023
27 of 28 checks passed
@yahavi yahavi deleted the fix-release branch December 4, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees

@yahavi yahavi

Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @attiasas