Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky Lifecycle tests #2329

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Nov 27, 2023

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Tests for Lifecycle are Flaky, issue is that there are sometimes where deleting the RB are not over while we want to delete the repository, causes:

10:38:41 [Error] Couldn't delete repository cli-rt-dev-macos-lifecycle-1694446144 : server response: 403
{
  "errors": [
    {
      "status": 403,
      "message": "Failed to delete repository 'cli-rt-dev-macos-lifecycle-1694446144' because it contains artifact/s related to at least 1 release bundles: [cli-lc-rb3-macos-lifecycle-1694446144:333]"
    }
  ]
}

Issue is that we only wait for Remote delete to finish, while normal delete also not implementing the "sync" even if we pass it

@attiasas attiasas marked this pull request as draft November 27, 2023 11:41
@attiasas attiasas added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Nov 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 27, 2023
@attiasas attiasas marked this pull request as ready for review November 27, 2023 11:47
@attiasas attiasas requested review from yahavi and eyalbe4 November 27, 2023 11:49
@eyalbe4 eyalbe4 changed the title Fix Flaky Lifecycle tests Fix flaky Lifecycle tests Nov 27, 2023
@attiasas attiasas merged commit 0fe0702 into jfrog:dev Nov 28, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants