Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove poetry integration tests for build-info #2323

Merged
merged 5 commits into from
Nov 26, 2023
Merged

Remove poetry integration tests for build-info #2323

merged 5 commits into from
Nov 26, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Nov 20, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Poetry is not supported for build-info, only for Audit.
Remove related tests

@attiasas attiasas added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Nov 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 20, 2023
@attiasas attiasas requested review from yahavi and eyalbe4 November 20, 2023 16:00
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

yahavi
yahavi requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more files to delete under testdata/poetry

utils/tests/consts.go Show resolved Hide resolved
@eyalbe4 eyalbe4 removed their request for review November 24, 2023 09:54
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 26, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 26, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 26, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 26, 2023
@attiasas attiasas merged commit 96ddaba into jfrog:dev Nov 26, 2023
62 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @yahavi