Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker Fat-Manifest test #2294

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Fix Docker Fat-Manifest test #2294

merged 2 commits into from
Nov 5, 2023

Conversation

Or-Geva
Copy link
Contributor

@Or-Geva Or-Geva commented Nov 4, 2023

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

TestPushFatManifestImage test fails with buildkit v0.12.3.
We pin v0.12.2 since buildkit v0.12.3 is getting a 401 unauthorized error when using a private HTTP insecure registry.

@Or-Geva Or-Geva requested a review from yahavi November 4, 2023 07:10
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Nov 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 4, 2023
@Or-Geva Or-Geva merged commit c9165bf into jfrog:dev Nov 5, 2023
10 of 11 checks passed
@Or-Geva Or-Geva added the ignore for release Automatically generated release notes label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants