Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestPipInstallNativeSyntax in Windows #2284

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix TestPipInstallNativeSyntax in Windows #2284

merged 2 commits into from
Oct 25, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 24, 2023

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@yahavi yahavi added the ignore for release Automatically generated release notes label Oct 24, 2023
@yahavi yahavi requested a review from eyalbe4 October 24, 2023 14:21
@yahavi yahavi self-assigned this Oct 24, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@yahavi yahavi merged commit 8809b7f into jfrog:dev Oct 25, 2023
10 of 11 checks passed
@yahavi yahavi deleted the fix-python-tests branch October 25, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees

@yahavi yahavi

Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4