New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestUploadWithArchiveAndSymlink #1269

Merged

yahavi merged 1 commit into jfrog:dev from yahavi:upload-archive-symlink-test

Nov 7, 2021

Member

yahavi commented Oct 27, 2021 •

edited

Loading

All tests passed. If this feature is not already covered by the tests, I added new tests.
This pull request is on the dev branch.
I used gofmt for formatting the code before submitting the pull request.

TestUploadWithArchiveAndSymlink creates a link to a file outside of the archive. This test failed because of the change in jfrog/jfrog-client-go#433.

Also new test added - TestUploadWithArchiveAndSymlinkZipSlip.
This test will fail on Windows until the merging of jfrog/jfrog-client-go#456


          Fix TestUploadWithArchiveAndSymlink

a38539d

yahavi requested review from eyalbe4 and gailazar300

October 27, 2021 14:57

yahavi self-assigned this

eyalbe4 approved these changes

View reviewed changes

yahavi merged commit f7ada36 into jfrog:dev

yahavi deleted the upload-archive-symlink-test branch

November 7, 2021 16:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet