Turn the signing key to be optional in RBC

jfrog · Nov 14, 2024 · 296600d · 296600d
1 parent ce298c1
commit 296600d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/lifecycle/cli.go b/lifecycle/cli.go
@@ -127,10 +127,6 @@ func validateCreateReleaseBundleContext(c *cli.Context) error {
 		return cliutils.WrongNumberOfArgumentsHandler(c)
 	}
 
-	if err := assertSigningKeyProvided(c); err != nil {
-		return err
-	}
-
 	return assertValidCreationMethod(c)
 }
 

diff --git a/lifecycle/cli_test.go b/lifecycle/cli_test.go
@@ -21,7 +21,7 @@ func TestValidateCreateReleaseBundleContext(t *testing.T) {
 		{"extraArgs", []string{"one", "two", "three", "four"}, []string{}, true},
 		{"bothSources", []string{"one", "two", "three"}, []string{cliutils.Builds + "=/path/to/file", cliutils.ReleaseBundles + "=/path/to/file"}, true},
 		{"noSources", []string{"one", "two", "three"}, []string{}, true},
-		{"builds without signing key", []string{"name", "version"}, []string{cliutils.Builds + "=/path/to/file"}, true},
+		{"builds without signing key", []string{"name", "version"}, []string{cliutils.Builds + "=/path/to/file"}, false},
 		{"builds correct", []string{"name", "version"}, []string{
 			cliutils.Builds + "=/path/to/file", cliutils.SigningKey + "=key"}, false},
 		{"releaseBundles without signing key", []string{"name", "version", "env"}, []string{cliutils.ReleaseBundles + "=/path/to/file"}, true},