Skip to content

Commit

Permalink
Remove duplicate argument in ServicesManagers (#104)
Browse files Browse the repository at this point in the history
* Removed ServiceDetails argument from the ctors of DistributionServicesManager and XrayServicesManager (it already exists in Config)

* Removed ServiceDetails argument from the ctors of DistributionServicesManager and XrayServicesManager (it already exists in Config)

* minor fixes
  • Loading branch information
asafgabai authored Apr 4, 2021
1 parent f2b0ce7 commit d7645ec
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion artifactory/utils/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ func CreateDistributionServiceManager(artDetails *config.ServerDetails, isDryRun
if err != nil {
return nil, err
}
return distribution.New(&distAuth, serviceConfig)
return distribution.New(serviceConfig)
}

func isRepoExists(repository string, artDetails auth.ServiceDetails) (bool, error) {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ require (
gopkg.in/yaml.v2 v2.3.0
)

replace github.com/jfrog/jfrog-client-go => github.com/jfrog/jfrog-client-go v0.20.3-0.20210331152013-5a17bc8b62d7
replace github.com/jfrog/jfrog-client-go => github.com/asafgabai/jfrog-client-go v0.18.1-0.20210404075639-33adaad627cb

replace github.com/jfrog/gocmd => github.com/jfrog/gocmd v0.1.20-0.20210330134550-459be3fc0ee8
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ github.com/anmitsu/go-shlex v0.0.0-20161002113705-648efa622239/go.mod h1:2FmKhYU
github.com/armon/circbuf v0.0.0-20150827004946-bbbad097214e/go.mod h1:3U/XgcO3hCbHZ8TKRvWD2dDTCfh9M9ya+I9JpbB7O8o=
github.com/armon/go-metrics v0.0.0-20180917152333-f0300d1749da/go.mod h1:Q73ZrmVTwzkszR9V5SSuryQ31EELlFMUz1kKyl939pY=
github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310/go.mod h1:ufUuZ+zHj4x4TnLV4JWEpy2hxWSpsRywHrMgIH9cCH8=
github.com/asafgabai/jfrog-client-go v0.18.1-0.20210404075639-33adaad627cb h1:alw8v+zhBgjp0Ax6hGhar4hTO4r7ToheYkU7DkA+PMk=
github.com/asafgabai/jfrog-client-go v0.18.1-0.20210404075639-33adaad627cb/go.mod h1:0RYDrQKCIdJbx6pjopwtwXh4/PaEW9FqFc4b4ox8fl0=
github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod h1:Dwedo/Wpr24TaqPxmxbtue+5NUziq4I4S80YR8gNf3Q=
github.com/beorn7/perks v1.0.0/go.mod h1:KWe93zE9D1o94FZ5RNwFwVgaQK1VOXiVxmqh+CedLV8=
github.com/bgentry/speakeasy v0.1.0/go.mod h1:+zsyZBPWlz7T6j88CTgSN5bM796AkVf0kBD4zp0CCIs=
Expand Down Expand Up @@ -131,8 +133,6 @@ github.com/jfrog/gocmd v0.1.20-0.20210330134550-459be3fc0ee8 h1:fCwjRZJEbW+Jl5aa
github.com/jfrog/gocmd v0.1.20-0.20210330134550-459be3fc0ee8/go.mod h1:sot5UIRHuLOG8NxAeyy6dKhm/r8xu+VWGIi7wFDU2Wg=
github.com/jfrog/gofrog v1.0.6 h1:yUDxSCw8gTK6vC4PvtG0HTnEOQJSZ+O4lWGCgkev1nU=
github.com/jfrog/gofrog v1.0.6/go.mod h1:HkDzg+tMNw23UryoOv0+LB94BzYcl6MCIoz8Tmlb+s8=
github.com/jfrog/jfrog-client-go v0.20.3-0.20210331152013-5a17bc8b62d7 h1:96xV8muG4of2FWd7UZUNcPOtzW6ZiIuY9YAgL5w0ejg=
github.com/jfrog/jfrog-client-go v0.20.3-0.20210331152013-5a17bc8b62d7/go.mod h1:0RYDrQKCIdJbx6pjopwtwXh4/PaEW9FqFc4b4ox8fl0=
github.com/jonboulle/clockwork v0.1.0/go.mod h1:Ii8DK3G1RaLaWxj9trq07+26W01tbo22gdxWY5EU2bo=
github.com/json-iterator/go v1.1.6/go.mod h1:+SdeFBvtyEkXs7REEP0seUULqWtbJapLOCVDaaPEHmU=
github.com/jstemmer/go-junit-report v0.0.0-20190106144839-af01ea7f8024/go.mod h1:6v2b51hI/fHJwM22ozAgKL4VKDeJcHhJFhtBdhmNjmU=
Expand Down

0 comments on commit d7645ec

Please sign in to comment.