-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Platform chart with 3-Node Artifactory with Distribution and direct-S3 Persistence #1949
base: master
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
examples/jfrog-platform/HA-with-distirbution-S3/values-openshift.yaml
Outdated
Show resolved
Hide resolved
examples/jfrog-platform/HA-with-distirbution-S3/values-main.yaml
Outdated
Show resolved
Hide resolved
examples/jfrog-platform/HA-with-distirbution-S3/values-main.yaml
Outdated
Show resolved
Hide resolved
| Private Registry | ✅ | | ||
|
||
|
||
Note: This requires distribution chart 102.23.0+ to work, which comes default with platform chart 10.17.4+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid this comment as it's confusing and brings up more questions. Since we already have 10.20.x out, we should be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should put this under the section with openshift. The original case was on openshift which distribution chart doesn't support until 102.23.0
|
||
To use IAM roles, check [here](https://jfrog.com/help/r/artifactory-how-to-configure-an-aws-s3-object-store-using-an-iam-role-instead-of-an-iam-user/artifactory-how-to-configure-an-aws-s3-object-store-using-an-iam-role-instead-of-an-iam-user) | ||
|
||
6. Pull charts ( if you need to reference the suggested sizing paramerters ) and install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain the use of the sizing files (which is the reason to pull the chart and untar it).
Also, consider adding a link to the reference architecture where we describe the sizings of the infrastructure as well.
https://jfrog.com/help/r/jfrog-platform-reference-architecture/jfrog-platform-reference-architecture
… and direct-S3 Persistence
…l database whenever possible, and ensure all information is passed securely using secrets.
…l database whenever possible, and ensure all information is passed securely using secrets.
- Updated S3 example to use IAM role - Modified OpenShift notes - Explained the use of sizing files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
<signatureExpirySeconds>600</signatureExpirySeconds> | ||
<maxConnections>50</maxConnections> | ||
<connectionTimeout>10000</connectionTimeout> | ||
<useInstanceCredentials>true</useInstanceCredentials> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add instructions on setting up the nodes role to include the "arn:aws:iam::aws:policy/AmazonS3FullAccess" policy
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory]
)What this PR does / why we need it:
added examples to deploy 3-Node Artifactory Cluster with Distribution and direct-S3 Persistence
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #n/a
Special notes for your reviewer:
adding more example usages of our chart based on real customer scenario.