Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Platform chart with 3-Node Artifactory with Distribution and direct-S3 Persistence #1949

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ypan887
Copy link
Contributor

@ypan887 ypan887 commented Jan 2, 2025

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:

added examples to deploy 3-Node Artifactory Cluster with Distribution and direct-S3 Persistence

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

n/a

Special notes for your reviewer:

adding more example usages of our chart based on real customer scenario.

Copy link

github-actions bot commented Jan 2, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ypan887
Copy link
Contributor Author

ypan887 commented Jan 2, 2025

I have read the CLA Document and I hereby sign the CLA

@chukka chukka changed the title [platform]added examples to deploy 3-Node Artifactory Cluster with Distribution… [examples] Platform chart with 3-Node Artifactory Cluster with Distribution and direct-S3 Persistence Jan 3, 2025
@chukka chukka changed the title [examples] Platform chart with 3-Node Artifactory Cluster with Distribution and direct-S3 Persistence [examples] Platform chart with 3-Node Artifactory with Distribution and direct-S3 Persistence Jan 3, 2025
| Private Registry | ✅ |


Note: This requires distribution chart 102.23.0+ to work, which comes default with platform chart 10.17.4+.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid this comment as it's confusing and brings up more questions. Since we already have 10.20.x out, we should be good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should put this under the section with openshift. The original case was on openshift which distribution chart doesn't support until 102.23.0


To use IAM roles, check [here](https://jfrog.com/help/r/artifactory-how-to-configure-an-aws-s3-object-store-using-an-iam-role-instead-of-an-iam-user/artifactory-how-to-configure-an-aws-s3-object-store-using-an-iam-role-instead-of-an-iam-user)

6. Pull charts ( if you need to reference the suggested sizing paramerters ) and install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain the use of the sizing files (which is the reason to pull the chart and untar it).
Also, consider adding a link to the reference architecture where we describe the sizings of the infrastructure as well.
https://jfrog.com/help/r/jfrog-platform-reference-architecture/jfrog-platform-reference-architecture

…l database whenever possible, and ensure all information is passed securely using secrets.
…l database whenever possible, and ensure all information is passed securely using secrets.
- Updated S3 example to use IAM role
- Modified OpenShift notes
- Explained the use of sizing files
Copy link
Contributor

@eldada eldada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<signatureExpirySeconds>600</signatureExpirySeconds>
<maxConnections>50</maxConnections>
<connectionTimeout>10000</connectionTimeout>
<useInstanceCredentials>true</useInstanceCredentials>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add instructions on setting up the nodes role to include the "arn:aws:iam::aws:policy/AmazonS3FullAccess" policy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants