Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gha docker pull #89

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Gha docker pull #89

merged 4 commits into from
Feb 21, 2024

Conversation

jflo
Copy link
Owner

@jflo jflo commented Feb 21, 2024

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and adding the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTests
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

Fixed Issue(s)

jflo and others added 4 commits February 21, 2024 09:19
* removes commenting on pr action, in favor of an updated pr template. also updates gradle build actions
* adds fix for nightly docker builds
* uses consolidation status to determine re-runs
* mention docker image registry in changelog
---------

Signed-off-by: Justin Florentine <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
* Add Besu version to DB metadata. Check for downgrades and reject if version < version recorded in DB metadata.

Signed-off-by: Matthew Whitehead <[email protected]>

* Add --allow-downgrade CLI arg. If set it allows the downgrade and updates the Besu version in the metadata file to the downgraded version.

Signed-off-by: Matthew Whitehead <[email protected]>

* Update gradle verification XML

Signed-off-by: Matthew Whitehead <[email protected]>

* Add and update tests

Signed-off-by: Matthew Whitehead <[email protected]>

* Refactoring

Signed-off-by: Matthew Whitehead <[email protected]>

* Remove versioning from RocksDB, now in separate VERSION_DATADATA.json

Signed-off-by: Matthew Whitehead <[email protected]>

* Tidy up and tests for the new class

Signed-off-by: Matthew Whitehead <[email protected]>

* Move downgrade logic into VersionMetadata as BesuCommand is already very big

Signed-off-by: Matthew Whitehead <[email protected]>

* Add more tests

Signed-off-by: Matthew Whitehead <[email protected]>

* Refactor the naming of the option to version-compatibility-protection

Signed-off-by: Matthew Whitehead <[email protected]>

* Remove remaining references to allow-downgrade

Signed-off-by: Matthew Whitehead <[email protected]>

* Rename test

Signed-off-by: Matthew Whitehead <[email protected]>

* Update comments

Signed-off-by: Matthew Whitehead <[email protected]>

* Metadata verification update

Signed-off-by: Matthew Whitehead <[email protected]>

* gradle fix

Signed-off-by: Matthew Whitehead <[email protected]>

* Enable version downgrade protection by default for non-named networks

Signed-off-by: Matthew Whitehead <[email protected]>

* Fix default logic

Signed-off-by: Matthew Whitehead <[email protected]>

* Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/VersionMetadata.java

Co-authored-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Matt Whitehead <[email protected]>

* Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/VersionMetadata.java

Co-authored-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Matt Whitehead <[email protected]>

* mock-maker-inline no longer needed

Signed-off-by: Matthew Whitehead <[email protected]>

---------

Signed-off-by: Matthew Whitehead <[email protected]>
Signed-off-by: Matt Whitehead <[email protected]>
Signed-off-by: Matt Whitehead <[email protected]>
Co-authored-by: Fabio Di Fabio <[email protected]>
@jflo jflo merged commit fe8c518 into main Feb 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants