Add FamilyUtils extensions #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice3point
requested changes
Jul 2, 2024
| private static object ResolveProfileSymbols(Document context) | ||
| { | ||
| var values = Enum.GetValues(typeof(ProfileFamilyUsage)); | ||
| var capacity = values.Length; |
There was a problem hiding this comment.
Multiply by 2. You have two results for one value
| foreach (ProfileFamilyUsage value in values) | ||
| { | ||
| variants.Add(FamilyUtils.GetProfileSymbols(context, value, false), value.ToString()); | ||
| variants.Add(FamilyUtils.GetProfileSymbols(context, value, true), $"{value.ToString()}, One curve loop only"); |
There was a problem hiding this comment.
Redundant .ToString() inside interpolation
|
|
||
| foreach (ProfileFamilyUsage value in values) | ||
| { | ||
| variants.Add(FamilyUtils.GetProfileSymbols(context, value, false), value.ToString()); |
There was a problem hiding this comment.
We have to add extra description to understand context. For example, this method with $"{value} with multiple curve loops" and next $"{value} with single curve loop"
There was a problem hiding this comment.
Forgot about this PR. I fixed it all
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Detected 202 dependenciesThird-party software listThis page lists the third-party software dependencies used in RevitLookup
Contact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
I added support for 2 methods of FamilyUtils class
Description:
Quality Checklist