Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Family Size Table support to Family Document #240

Merged
merged 2 commits into from
May 18, 2024
Merged

Add Family Size Table support to Family Document #240

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31aa432
Add Family Size Table support to Family Document
SergeyNefyodov May 18, 2024
9716585
Add Family Size Table support to Family Document
SergeyNefyodov May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion source/RevitLookup/Core/ComponentModel/Descriptors/DocumentDescriptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

namespace RevitLookup.Core.ComponentModel.Descriptors;

public sealed class DocumentDescriptor : Descriptor, IDescriptorResolver
public sealed class DocumentDescriptor : Descriptor, IDescriptorResolver, IDescriptorExtension
{
private readonly Document _document;

Expand Down Expand Up @@ -71,4 +71,14 @@ IVariants ResolveGetAllUnusedElements()
}
#endif
}

public void RegisterExtensions(IExtensionManager manager)
{
if (!_document.IsFamilyDocument) return;
manager.Register(nameof(FamilySizeTableManager.GetFamilySizeTableManager), context =>
{
var result = FamilySizeTableManager.GetFamilySizeTableManager(_document, new ElementId(BuiltInParameter.RBS_LOOKUP_TABLE_NAME));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use context arg instead of _document field to avoid closure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

return Variants.Single(result);
});
}
}