Add phases support for Element, fix FamilyInstance phases bug #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NET2 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Nice3point
requested changes
May 15, 2024
Comment on lines
67
to
68
| if (_familyInstance.GetPhaseStatus(phase.Id) != ElementOnPhaseStatus.Future) | ||
| variants.Add(_familyInstance.get_FromRoom(phase), phase.Name); |
There was a problem hiding this comment.
invert IF to reduse nesting and better readability. Include lines below
There was a problem hiding this comment.
ElementOnPhaseStatus.Future gets an exception, right ?
…s-support # Conflicts: # source/RevitLookup/Core/ComponentModel/Descriptors/FamilyInstanceDescriptor.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
There was a bug: we didn't see ToRoom(Phase), when there was at least one Phase with status Future. But to understand this reason, I needed to add support to Element methods about Phases
Quality Checklist