Add support to TableData class #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Nice3point
reviewed
Apr 27, 2024
|
|
||
| var zoom = 0; | ||
| var emptyIterations = 0; | ||
| while (emptyIterations < 50) |
There was a problem hiding this comment.
@SergeyNefyodov i've optimized a little bit. I guess while loop looks better for this case. But maybe, zoom list is constant, from 10 to 400 with step 10, but who knows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
Description:
I added support to TableData class. I tried to resolve IsValidZoomLevel method. It returns true on all the numbers ends on 0, from 10 to 400, others are False. I decided to remain only true values, otherwise it would be inconvinient for user. A loop with 511 iteration is surprisingly fast, maybe it can be OK. I remain 511 in case of 400 is not the greatest scale