Add support for Panels and Curtain Grids #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice3point
reviewed
Apr 9, 2024
Comment on lines
33
to
34
| uLinesIds.Add(ElementId.InvalidElementId); | ||
| vLinesIds.Add(ElementId.InvalidElementId); |
There was a problem hiding this comment.
Add InvalidElementId ? What's the reason ?
|
That's awesome, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
I added support for CurtainGrid class: GetPanel and GetCell; and for Panel class: GetRefGridLines
GetRefGridLines returns void, but has 2 refs arguments, so I suggest to change order of checks in DescriptorBuilder.cs.
Quality Checklist