Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate thread for UI #166

Merged
merged 4 commits into from
May 26, 2023
Merged

Separate thread for UI #166

merged 4 commits into from
May 26, 2023

Conversation

Nice3point
Copy link
Collaborator

@Nice3point Nice3point commented May 18, 2023

Summary of the Pull Request

What is this about:

Support for a new thread for the user interface

Description:

The feature is added to the existing "Hardware acceleration" option.
The new thread allows us to offload the main thread and reduce interface freezes while Revit performs its tasks.

Need more tests to add this feature and possibly change the code. Turning it off closes all instances of RevitLookup, which may come as a surprise

Quality Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Nice3point Nice3point changed the title Dev threads Separate thread for UI May 18, 2023
@Nice3point Nice3point added feature 💡 A new feature being implemented open discussion ☎️ An issue open for active community discussion labels May 18, 2023
@Nice3point
Copy link
Collaborator Author

The new thread probably gets around this issue #155 and situations where with a selected roof the UI slows down a lot, even in Revit itself.

@Nice3point Nice3point marked this pull request as ready for review May 26, 2023 10:43
@Nice3point Nice3point requested a review from jeremytammik as a code owner May 26, 2023 10:43
@jeremytammik jeremytammik merged commit adc82da into dev May 26, 2023
@Nice3point Nice3point deleted the dev_threads branch May 29, 2023 20:02
jeremytammik pushed a commit that referenced this pull request Jun 1, 2023
* Cleanup

* Update Nuke

* Fix GetMaterialIds

* DefinitionGroup support

* Disable Show for ElementType

* Demo project restore

* Nuke update

* Material area, volume support

* Static members support

* Update Changelog.md

* Update nuget packages

* Update Codeowners

* FamilyInstance rooms support

* Update Changelog.md

* Separate UI thread

* CleanUp

* Remove debug RenderOptions

* Fix initialisation render mode

* Separate thread for UI (#166)

* Separate UI thread

* Remove debug RenderOptions

* Fix initialisation render mode

* Update Build.Installer

* Fix context menu dispatcher

* Icons support

* Icons support (#167)

* Pages virtualization

* Category redirection support

* Rework metadata builder

* Fields, events support

* Fix R24 compability

* Bump version

* Update Contributing.md

* Update Changelog.md

* Update Changelog.md

* Update icon

* Disable transition by default

* Enhanced member support (#168)

* Fields, events support

* Fix R24 compability

* Update icon

* Disable transition by default

* Icons update

* Update Changelog.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 💡 A new feature being implemented open discussion ☎️ An issue open for active community discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants