[EngSys] upgrade typescript-eslint* dev dependencies to ~8.23.0 (Azur…

…e#32883)
jeremymeng · Feb 5, 2025 · 007450f · 007450f
1 parent 0f7f43f
commit 007450f
Show file tree

Hide file tree

Showing 7 changed files with 97 additions and 116 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/common/tools/dev-tool/package.json b/common/tools/dev-tool/package.json
@@ -93,7 +93,7 @@
     "eslint": "^9.9.0",
     "mkdirp": "^3.0.1",
     "rimraf": "^5.0.5",
-    "typescript-eslint": "~8.16.0",
+    "typescript-eslint": "~8.23.0",
     "uglify-js": "^3.4.9",
     "vitest": "^3.0.3",
     "@types/unzipper": "~0.10.10"

diff --git a/common/tools/eslint-plugin-azure-sdk/package.json b/common/tools/eslint-plugin-azure-sdk/package.json
@@ -86,8 +86,8 @@
   "prettier": "./prettier.json",
   "peerDependencies": {
     "@eslint/eslintrc": "^3.2.0",
-    "@typescript-eslint/eslint-plugin": "~8.16.0",
-    "@typescript-eslint/parser": "~8.16.0",
+    "@typescript-eslint/eslint-plugin": "~8.23.0",
+    "@typescript-eslint/parser": "~8.23.0",
     "eslint": "^9.9.0",
     "eslint-plugin-markdown": "^5.0.0",
     "eslint-plugin-n": "^17.15.0",
@@ -100,22 +100,22 @@
     "@eslint/js": "^9.9.0",
     "@types/eslint": "^9.6.0",
     "@types/estree": "~1.0.0",
-    "@typescript-eslint/typescript-estree": "~8.16.0",
+    "@typescript-eslint/typescript-estree": "~8.23.0",
     "eslint-config-prettier": "^10.0.1",
     "glob": "^10.3.10",
     "tslib": "^2.6.2",
     "typescript": "~5.7.2",
-    "typescript-eslint": "~8.16.0"
+    "typescript-eslint": "~8.23.0"
   },
   "devDependencies": {
     "@types/eslint": "^9.6.0",
     "@types/eslint__js": "8.42.3",
     "@types/eslint-config-prettier": "6.11.3",
     "@types/node": "^18.0.0",
-    "@typescript-eslint/eslint-plugin": "~8.16.0",
-    "@typescript-eslint/parser": "~8.16.0",
-    "@typescript-eslint/rule-tester": "~8.16.0",
-    "@typescript-eslint/utils": "~8.16.0",
+    "@typescript-eslint/eslint-plugin": "~8.23.0",
+    "@typescript-eslint/parser": "~8.23.0",
+    "@typescript-eslint/rule-tester": "~8.23.0",
+    "@typescript-eslint/utils": "~8.23.0",
     "@vitest/browser": "^3.0.3",
     "@vitest/coverage-istanbul": "^3.0.3",
     "eslint": "^9.9.0",

diff --git a/common/tools/vite-plugin-browser-test-map/package.json b/common/tools/vite-plugin-browser-test-map/package.json
@@ -58,6 +58,6 @@
     "prettier": "^3.3.3",
     "rimraf": "^5.0.0",
     "typescript": "~5.7.2",
-    "typescript-eslint": "~8.16.0"
+    "typescript-eslint": "~8.23.0"
   }
 }
diff --git a/sdk/identity/identity-broker/samples/v1/typescript/package.json b/sdk/identity/identity-broker/samples/v1/typescript/package.json
@@ -37,7 +37,7 @@
     "@types/node": "^18.0.0",
     "@eslint/js": "^9.9.0",
     "eslint": "^9.9.0",
-    "typescript-eslint": "~8.16.0",
+    "typescript-eslint": "~8.23.0",
     "typescript": "~5.7.2",
     "rimraf": "^5.0.0"
   }

diff --git a/sdk/monitor/monitor-opentelemetry/src/metrics/quickpulse/utils.ts b/sdk/monitor/monitor-opentelemetry/src/metrics/quickpulse/utils.ts
@@ -366,12 +366,15 @@ export function getLogData(log: LogRecord): ExceptionData | TraceData {
   const customDims = createCustomDimsFromAttributes(log.attributes);
   if (isExceptionTelemetry(log)) {
     return {
+      // eslint-disable-next-line @typescript-eslint/no-base-to-string
       Message: String(log.attributes[SEMATTRS_EXCEPTION_MESSAGE]),
+      // eslint-disable-next-line @typescript-eslint/no-base-to-string
       StackTrace: String(log.attributes[SEMATTRS_EXCEPTION_STACKTRACE]),
       CustomDimensions: customDims,
     };
   } else {
     return {
+      // eslint-disable-next-line @typescript-eslint/no-base-to-string
       Message: String(log.body),
       CustomDimensions: customDims,
     };
@@ -460,6 +463,7 @@ function createCustomDimsFromAttributes(
           key === SEMATTRS_EXCEPTION_STACKTRACE
         )
       ) {
+        // eslint-disable-next-line @typescript-eslint/no-base-to-string
         customDims.set(key, String(attributes[key]));
       }
     }

diff --git a/sdk/monitor/monitor-opentelemetry/src/metrics/utils.ts b/sdk/monitor/monitor-opentelemetry/src/metrics/utils.ts
@@ -154,6 +154,7 @@ export function isTraceTelemetry(logRecord: LogRecord): boolean {
 }
 
 export function isSyntheticLoad(record: LogRecord | ReadableSpan): boolean {
+  // eslint-disable-next-line @typescript-eslint/no-base-to-string
   const userAgent = String(record.attributes[SEMATTRS_HTTP_USER_AGENT]);
   return userAgent !== null && userAgent.includes("AlwaysOn") ? true : false;
 }