Reuse completed build result

Instead of invoking `completedRun.getResult()` several times, invoke it once and reuse the resust. That makes the code slightly easier to read.
jenkinsci · Oct 18, 2024 · f60b7e3 · f60b7e3
1 parent aa92dfe
commit f60b7e3
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java b/src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java
@@ -179,20 +179,21 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
                                                 + " started.");
 
                                 Run completedRun = future.get();
+                                Result completedResult = completedRun.getResult();
                                 listener.getLogger()
                                         .println(HyperlinkNote.encodeTo(
                                                         '/' + completedRun.getUrl(),
                                                         completedRun.getFullDisplayName())
-                                                + " completed. Result was " + completedRun.getResult());
+                                                + " completed. Result was " + completedResult);
                                 BuildInfoExporterAction.addBuildInfoExporterAction(
                                         build,
                                         completedRun.getParent().getFullName(),
                                         completedRun.getNumber(),
-                                        completedRun.getResult());
+                                        completedResult);
 
                                 if (buildStepResult
-                                        && config.getBlock().mapBuildStepResult(completedRun.getResult())) {
-                                    Result r = config.getBlock().mapBuildResult(completedRun.getResult());
+                                        && config.getBlock().mapBuildStepResult(completedResult)) {
+                                    Result r = config.getBlock().mapBuildResult(completedResult);
                                     if (r != null) { // The blocking job is not a success
                                         build.setResult(r);
                                     }