Skip to content

Commit

Permalink
PrintFailingTestsBuildToChatNotifier.java: move comment about code th…
Browse files Browse the repository at this point in the history
…at confused spotbugs
  • Loading branch information
jimklimov committed Nov 30, 2022
1 parent d902607 commit 8afc721
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,14 @@ private CharSequence getFailedTestsReport(Run<?, ?> build) {
}

StringBuilder buf = new StringBuilder();
// SIC_INNER_SHOULD_BE_STATIC_ANON.... whatever that means:
// The class hudson.plugins.im.build_notify.PrintFailingTestsBuildToChatNotifier$1
// could be refactored into a named _static_ inner class.
// IDEA says: Unchecked assignment: 'java.util.List' to 'java.util.List<hudson.tasks.junit.CaseResult>'.
// Reason: 'testResultAction' has raw type, so result of getFailedTests is erased.
// and suggests to change to "raw" List, then complains it is raw :\
List<CaseResult> failedTests = testResultAction.getFailedTests();

// SIC_INNER_SHOULD_BE_STATIC_ANON.... whatever that means:
// The class hudson.plugins.im.build_notify.PrintFailingTestsBuildToChatNotifier$1
// could be refactored into a named _static_ inner class.
Collections.sort(failedTests, new Comparator<CaseResult>() {
@Override
public int compare(CaseResult o1, CaseResult o2) {
Expand Down

0 comments on commit 8afc721

Please sign in to comment.